[Per Bothner <per@bothner.com>] Re: forwarded message from Adam Heath

[Tom Tromey <tromey@redhat.com>]

This is undoubtedly the cause of the jar problem we were seeing.
fastjar's `u' option doesn't work.

Tom
------- Start of forwarded message -------
Message-ID: <3BD8A174.2030104@bothner.com>
Date: Thu, 25 Oct 2001 16:34:12 -0700
From: Per Bothner <per@bothner.com>
MIME-Version: 1.0
To: 116145@bugs.debian.org
CC: java@gcc.gnu.org
Subject: Re: forwarded message from Adam Heath
References: <15320.39495.965333.183669@gargle.gargle.HOWL>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=us-ascii; format=flowed

Matthias Klose wrote:

>Not only does fastjar obliterate existing contents in a jar when updating,
>but, it appears it can also corrupt the file.
>
Yes, I ran into the same problem.  Basically the implementation of 'u'
is pretty much not there.  I looked at trying to fix it, but decided I 
didn't
have time.  Until somebody fixes it, we should change fastjar to exit 
with an
error on 'u'.

The first question is whether fastjar should try to update
in place or create a temporary file and copy it over.  The former is faster,
especially when just adding files, and is less liable to run out of disk 
space.
However, it is tricky when files are replaced that are not at the end. 
 In that
case I guess the solution is to read the archive members that need to be 
moved
into main memory.

Then it is just a small matter of programming ...

------- End of forwarded message -------