From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27305 invoked by alias); 10 Jul 2003 17:30:38 -0000 Mailing-List: contact rhug-rhats-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: rhug-rhats-owner@sources.redhat.com Received: (qmail 27297 invoked from network); 10 Jul 2003 17:30:37 -0000 Received: from unknown (HELO gash2.peakpeak.com) (207.174.178.17) by sources.redhat.com with SMTP; 10 Jul 2003 17:30:37 -0000 Received: from fleche.redhat.com (tf0005.peakpeak.com [204.144.239.5]) by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id LAA19651; Thu, 10 Jul 2003 11:30:35 -0600 Received: by fleche.redhat.com (Postfix, from userid 1000) id CCE7D4F82F2; Thu, 10 Jul 2003 11:21:35 -0600 (MDT) To: rhug-rhats@sources.redhat.com Subject: bug fix -- but no automake From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom X-Zippy: I want to dress you up as TALLULAH BANKHEAD and cover you with VASELINE and WHEAT THINS.. Date: Thu, 10 Jul 2003 17:30:00 -0000 Message-ID: <87of02b8m8.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-07/txt/msg00000.txt.bz2 I don't have automake 1.5 installed anywhere. (This is a bogus version to be using, anyway. 1.6 or 1.7 would be much better.) This patch fixes a build problem I've been having. CFLAGS is a user variable, setting it in Makefile.am is incorrect. And in this case it breaks the build if you try to build with "make CFLAGS=-g". Could someone here with automake 1.5 apply this patch, rebuild Makefile.in, and commit? I'd appreciate it if this could happen soon... I'd like my nightly builds to start working again so I can use jasmin. I searched in all the Makefile.am in the tree and didn't see this problem anywhere else, for either CFLAGS or CXXFLAGS. Tom Index: ChangeLog from Tom Tromey * Makefile.am (AM_CFLAGS): Renamed from CFLAGS. Removed -O2; this is supplied by configure. Index: Makefile.am =================================================================== RCS file: /cvs/rhug/rhug/gnu.readline/Makefile.am,v retrieving revision 1.10 diff -u -r1.10 Makefile.am --- Makefile.am 11 Jul 2002 13:49:29 -0000 1.10 +++ Makefile.am 10 Jul 2003 17:25:47 -0000 @@ -89,7 +89,7 @@ # JavaReadLine and JavaEditLine should be set according to what # autoconf detects. FIXME -CFLAGS = -O2 -DJNIEXPORT= -DJNICALL= -DJAVAREADLINE +AM_CFLAGS = -DJNIEXPORT= -DJNICALL= -DJAVAREADLINE lib_org_gnu_readline_la_SOURCES = \ ./upstream/src/org/gnu/readline/Readline.java \