public inbox for sid-cvs@sourceware.org
help / color / mirror / Atom feed
* src/sid/include ChangeLog sidcpuutil.h
@ 2001-06-24 17:26 bje
  0 siblings, 0 replies; 20+ messages in thread
From: bje @ 2001-06-24 17:26 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	bje@sources.redhat.com	2001-06-24 17:26:29

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	2001-06-24  Ben Elliston  <bje@redhat.com>
	
	* sidcpuutil.h (basic_cpu::total_latency): New member.
	(basic_cpu constructor): Initialise it.
	(basic_cpu::step_pin_handler): Include latency in cycle counts.
	(basic_cpu::latency_to_cycles): New virtual method.
	(basic_cpu::read_insn_memory): Add bus latency to total_latency.
	(basic_cpu::write_insn_memory): Ditto.
	(basic_cpu::read_data_memory): Ditto.
	(basic_cpu::write_data_memory): Ditto.
	(basic_cpu::stream_state): Add total_latency to state snapshot.
	(basic_cpu::destream_state): Likewise.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.16&r2=1.17
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.6&r2=1.7


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2006-09-27 20:28 brolley
  0 siblings, 0 replies; 20+ messages in thread
From: brolley @ 2006-09-27 20:28 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	brolley@sourceware.org	2006-09-27 20:28:22

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	2006-09-27  Dave Brolley  <brolley@redhat.com>
	
	* sidcpuutil.h (basic_cpu::configure): Set gprof_prev_cycle to
	total_insn_count when gprof 'cycles' not specified.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.66&r2=1.67
http://sourceware.org/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.38&r2=1.39


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2006-06-26 21:04 brolley
  0 siblings, 0 replies; 20+ messages in thread
From: brolley @ 2006-06-26 21:04 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	brolley@sourceware.org	2006-06-26 21:04:00

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	2006-06-26  Dave Brolley  <brolley@redhat.com>
	
	* commonCfg.cxx (GprofCfg): Connect the cpu's gprof-pc and gprof-pc-hi
	pins to our pc and p-hi pins respectively.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.65&r2=1.66
http://sourceware.org/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.37&r2=1.38


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2006-06-20 18:13 brolley
  0 siblings, 0 replies; 20+ messages in thread
From: brolley @ 2006-06-20 18:13 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	brolley@sourceware.org	2006-06-20 18:13:45

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	2006-06-20  Dave Brolley  <brolley@redhat.com>
	
	* sidcpuutil.h (basic_cpu): Remove gprof_prev_latency. Add
	gprof_prev_cycle, gprof_unconfigured_p.
	(sample_gprof): Now takes bool argument. Compute number of samples
	based on total_insn_count + current_step_insn_count + total_latency.
	(unconfigure_gprof): Set gprof_unconfigured_p.
	(configure_gprof): Only reset gprof_pref_cycle if gprof_unconfigured_p
	is true.
	(configure): When configuring --insn-count reset gprof_prev_cycle.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.64&r2=1.65
http://sourceware.org/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.36&r2=1.37


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2006-06-14 20:39 brolley
  0 siblings, 0 replies; 20+ messages in thread
From: brolley @ 2006-06-14 20:39 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	brolley@sourceware.org	2006-06-14 20:39:31

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	2006-06-14  Dave Brolley  <brolley@redhat.com>
	
	* sidcpuutil.h (basic_cpu::sample_gprof_pin): New pin.
	(sample_gprof): New method of basic_cpu.
	(step_pin_handler): Don't reset current_step_insn_count.
	Call sample_gprof, if requested and save latency.
	(stop_after_insns_p): Likewise.
	(unconfigure_gprof): Now takes no arguments. Remove unused code.
	Disconnect the sample_gprof_pin.
	(configure_gprof): Now takes configuration string. Connect the
	sample_gprof_pin. Determine the sampling mode.
	(gprof_cycles,gprof_counter,gprof_prev_latency): New members of
	basic_cpu.
	(configure): Initialize gprof_counter.
	(basic_cpu): Add sample-gprof pin.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.63&r2=1.64
http://sourceware.org/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.35&r2=1.36


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2006-05-11 19:29 brolley
  0 siblings, 0 replies; 20+ messages in thread
From: brolley @ 2006-05-11 19:29 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	brolley@sourceware.org	2006-05-11 19:29:51

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	2006-05-11  Dave Brolley  <brolley@redhat.com>
	
	* sidcpuutil.h (cg_profile): Now virtual.
	(cg_profile_jump): Now virtual.
	(dynamic_config): New vritual override.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.62&r2=1.63
http://sourceware.org/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.34&r2=1.35


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2005-11-14 20:05 brolley
  0 siblings, 0 replies; 20+ messages in thread
From: brolley @ 2005-11-14 20:05 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	brolley@sourceware.org	2005-11-14 20:05:16

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	2005-11-14  Dave Brolley  <brolley@redhat.com>
	
	* sidcpuutil.h (basic_cpu::pin_factory): Parse, recognize and add
	watchable register and virtual pin for names representing hardware
	watchpoints.
	(read_data_memory_*): Make accessible as virtual methods from basic_cpu.
	(read_watchpoint_memory): New method of basic_cpu.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.60&r2=1.61
http://sourceware.org/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.32&r2=1.33


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2005-08-23 21:09 brolley
  0 siblings, 0 replies; 20+ messages in thread
From: brolley @ 2005-08-23 21:09 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	brolley@sourceware.org	2005-08-23 21:09:24

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	2005-08-23  Dave Brolley  <brolley@redhat.com>
	
	* sidcpuutil.h (step_pin_handler): Don't call configure_gprof here.
	(unconfigure_gprof): Check gprof_configured_p.
	(configure_gprof): Check gprof_configured_p.
	(configure_gprof_p): Removed.
	(gprof_spec): Removed.
	(configure): Call configure_gprof here.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.59&r2=1.60
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.31&r2=1.32


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2004-03-22 21:28 brolley
  0 siblings, 0 replies; 20+ messages in thread
From: brolley @ 2004-03-22 21:28 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	brolley@sourceware.org	2004-03-22 21:28:19

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	2004-03-22  Dave Brolley  <brolley@redhat.com>
	
	* sidcpuutil.h (trace_pin): New member of basic_cpu.
	(trace_pin_handler): New method of basic_cpu.
	(basic_cpu): Add and initialize trace_pin.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.50&r2=1.51
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.27&r2=1.28


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2003-08-29 19:27 brolley
  0 siblings, 0 replies; 20+ messages in thread
From: brolley @ 2003-08-29 19:27 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	brolley@sourceware.org	2003-08-29 19:27:05

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	003-08-21  Dave Brolley  <brolley@redhat.com>
	
	* sidcpuutil.h (end_line): New method of basic_cpu::cpu_trace_stream.
	(operator<<): Use static_cast instead of dynamic_cast.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.47&r2=1.48
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.25&r2=1.26


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2003-04-16 18:15 brolley
  0 siblings, 0 replies; 20+ messages in thread
From: brolley @ 2003-04-16 18:15 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	brolley@sourceware.org	2003-04-16 18:15:16

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	2003-04-16  Dave Brolley  <brolley@redhat.com>
	
	* sidcpuutil.h (final_insn_count_p): New member of basic_cpu.
	(update_total_latency): New method of basic_cpu.
	(stream_state): Output final_insn_count_p.
	(destream_state): Input final_insn_count_p.
	(basic_cpu): Add attribute final-insn-count.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.44&r2=1.45
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.24&r2=1.25


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2003-01-15 20:03 brolley
  0 siblings, 0 replies; 20+ messages in thread
From: brolley @ 2003-01-15 20:03 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	brolley@sourceware.org	2003-01-15 12:03:35

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	2003-01-15  Dave Brolley  <brolley@redhat.com>
	
	* sidcpuutil.h (sidutil): Add total_insn_count when computing
	simulated cycles.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.42&r2=1.43
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.23&r2=1.24


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2002-11-28 22:05 bje
  0 siblings, 0 replies; 20+ messages in thread
From: bje @ 2002-11-28 22:05 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	bje@sourceware.org	2002-11-28 21:52:42

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	2002-11-29  Ben Elliston  <bje@redhat.com>
	
	* sidcpuutil.h (basic_cpu::print_insn_summary_pin): New pin.
	(basic_cpu::print_insn_summary): New virtual method.
	(basic_cpu::basic_cpu): Construct print_insn_summary_pin and
	instantiate it with add_pin().

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.41&r2=1.42
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.22&r2=1.23


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2002-10-03 14:00 brolley
  0 siblings, 0 replies; 20+ messages in thread
From: brolley @ 2002-10-03 14:00 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	brolley@sources.redhat.com	2002-10-03 14:00:49

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	2002-10-03  Dave Brolley  <brolley@redhat.com>
	From Ben Elliston  <bje@redhat.com>
	
	* sidcpuutil.h (basic_cpu::disassembler_bus): New accessor.
	(basic_cpu::basic_cpu): Initialise; register "disassembler-memory".

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.38&r2=1.39
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.19&r2=1.20


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2002-04-23 14:00 bje
  0 siblings, 0 replies; 20+ messages in thread
From: bje @ 2002-04-23 14:00 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	bje@sources.redhat.com	2002-04-23 14:00:35

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	2002-04-23  Ben Elliston  <bje@redhat.com>
	
	* sidcpuutil.h (basic_cpu::update_trace_destination): Open trace
	file in append mode.  Prefix trace session data with "start of
	trace" text.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.36&r2=1.37
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.18&r2=1.19


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2001-07-06  1:15 bje
  0 siblings, 0 replies; 20+ messages in thread
From: bje @ 2001-07-06  1:15 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	bje@sources.redhat.com	2001-07-06 01:14:57

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	2001-07-06  Ben Elliston  <bje@redhat.com>
	
	* sidcpuutil.h: Use std::string for C++ conformance.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.20&r2=1.21
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.7&r2=1.8


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2001-05-30 12:27 fche
  0 siblings, 0 replies; 20+ messages in thread
From: fche @ 2001-05-30 12:27 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	fche@sources.redhat.com	2001-05-30 12:27:51

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	* consistency fix
	
	2001-05-30  Frank Ch. Eigler  <fche@redhat.com>
	
	* sidcpuutil.h (step_pin_handler): Check for triggerpoints due right
	now, before instruction evaluation loop.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.12&r2=1.13
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.5&r2=1.6


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2001-05-23 17:00 bje
  0 siblings, 0 replies; 20+ messages in thread
From: bje @ 2001-05-23 17:00 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	bje@sources.redhat.com	2001-05-23 17:00:40

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	2001-05-24  Ben Elliston  <bje@redhat.com>
	
	* sidcpuutil.h (basic_cpu::create_gdb_register_attrs): Document
	the meaning of the expedited_regno_list argument.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.10&r2=1.11
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.4&r2=1.5


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2001-03-26 14:35 brolley
  0 siblings, 0 replies; 20+ messages in thread
From: brolley @ 2001-03-26 14:35 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	brolley@sources.redhat.com	2001-03-26 14:35:39

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	2001-03-26  Dave Brolley  <brolley@redhat.com>
	
	* sidcpuutil.h (basic_cpu::stepped): Make it virtual and public so
	it can be overridden.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.7&r2=1.8
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.3&r2=1.4


^ permalink raw reply	[flat|nested] 20+ messages in thread
* src/sid/include ChangeLog sidcpuutil.h
@ 2001-01-10 11:41 fche
  0 siblings, 0 replies; 20+ messages in thread
From: fche @ 2001-01-10 11:41 UTC (permalink / raw)
  To: sid-cvs

CVSROOT:	/cvs/src
Module name:	src
Changes by:	fche@sources.redhat.com	2001-01-10 11:41:01

Modified files:
	sid/include    : ChangeLog sidcpuutil.h 

Log message:
	* robustness incentive
	
	2001-01-10  Frank Ch. Eigler  <fche@redhat.com>
	
	* sidcpuutil.h (basic_cpu): Inherit from fixed_relation_map_component.
	Define a operator new/delete pair to poison new memory.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/ChangeLog.diff?cvsroot=src&r1=1.1&r2=1.2
http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/sid/include/sidcpuutil.h.diff?cvsroot=src&r1=1.1&r2=1.2


^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2006-09-27 20:28 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-06-24 17:26 src/sid/include ChangeLog sidcpuutil.h bje
  -- strict thread matches above, loose matches on Subject: below --
2006-09-27 20:28 brolley
2006-06-26 21:04 brolley
2006-06-20 18:13 brolley
2006-06-14 20:39 brolley
2006-05-11 19:29 brolley
2005-11-14 20:05 brolley
2005-08-23 21:09 brolley
2004-03-22 21:28 brolley
2003-08-29 19:27 brolley
2003-04-16 18:15 brolley
2003-01-15 20:03 brolley
2002-11-28 22:05 bje
2002-10-03 14:00 brolley
2002-04-23 14:00 bje
2001-07-06  1:15 bje
2001-05-30 12:27 fche
2001-05-23 17:00 bje
2001-03-26 14:35 brolley
2001-01-10 11:41 fche

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).