From: Ben Elliston <bje@redhat.com>
To: fche@redhat.com (Frank Ch. Eigler)
Cc: sid@sources.redhat.com
Subject: Re: new cache component
Date: Wed, 20 Jun 2001 23:30:00 -0000 [thread overview]
Message-ID: <15153.38017.120367.227244@scooby.brisbane.redhat.com> (raw)
In-Reply-To: <o5y9qtagr4.fsf@toenail.toronto.redhat.com>
>>>>> "Frank" == Frank Ch Eigler <fche@redhat.com> writes:
Frank> Good stuff. I like the cache_line/cache_set abstractions. A
Frank> few nits with respect to the code:
Thanks for taking the time to review it.
Frank> - The nomenclature of cache component type names is perhaps
Frank> too complicated. Some of the parameters specified in the
Frank> type name could (should?) be treated as attributes instead.
Frank> (However, then one would have to address the issue of their
Frank> run-time changeability.)
"I hear you." :-)
After much deliberation, I opted for the component type names to carry
the configuration parameters. The runtime changeability was just too
onerous. I tried to keep the naming scheme uniform and intuitive.
Frank> In any case, the type name parsing routine in CacheCreate()
Frank> could benefit from sidutil::tokenize(),
Frank> or even better, from using a fixed list of type-names and
Frank> parameters, like the flash memory components do.
I have made a change to use tokenize(), but I think I like the idea of
a lookup table better instead. I'll make that change.
Frank> - In a couple of places, sidutil::parse_attribute() is called
Frank> but its return value is not checked. Naughty!
Ooo, errr ..
Frank> - Consider adding TODOs for future support for bus snooping, leading
Frank> to cache coherency protocols
.. and ..
Frank> - Consider adding per-cache-line statistics (to detect if accesses
Frank> are not distributed nicely amongst the lines).
Both TODOs, I'm afraid. :-(
Ben
next prev parent reply other threads:[~2001-06-20 23:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <15145.36560.815865.750859.cygnus.project.sid@scooby.apac.redhat.com>
2001-06-15 8:46 ` Frank Ch. Eigler
2001-06-20 23:30 ` Ben Elliston [this message]
2001-06-14 21:28 Ben Elliston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15153.38017.120367.227244@scooby.brisbane.redhat.com \
--to=bje@redhat.com \
--cc=fche@redhat.com \
--cc=sid@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).