From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26234 invoked by alias); 2 Feb 2005 08:41:16 -0000 Mailing-List: contact sid-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: sid-owner@sources.redhat.com Received: (qmail 25952 invoked from network); 2 Feb 2005 08:40:58 -0000 Received: from unknown (HELO neon-gw.transmeta.com) (63.209.4.196) by sourceware.org with SMTP; 2 Feb 2005 08:40:58 -0000 Received: from victor.transmeta.com (victor.transmeta.com [10.0.2.120]) by neon-gw.transmeta.com (Postfix) with ESMTP id B05515F803C; Wed, 2 Feb 2005 00:40:54 -0800 (PST) Received: from localhost (localhost.localdomain [127.0.0.1]) by localhost.transmeta.com (Postfix) with ESMTP id 150A94F802E; Wed, 2 Feb 2005 00:40:58 -0800 (PST) Received: from victor.transmeta.com ([127.0.0.1]) by localhost (victor [127.0.0.1]) (amavisd-new, port 10022) with LMTP id 20329-06-8; Wed, 2 Feb 2005 00:40:58 -0800 (PST) Received: from casey.transmeta.com (casey.transmeta.com [10.10.25.22]) by victor.transmeta.com (Postfix) with ESMTP id EF3284F802D; Wed, 2 Feb 2005 00:40:57 -0800 (PST) Received: (from dje@localhost) by casey.transmeta.com (8.11.6/8.11.6) id j128erw21810; Wed, 2 Feb 2005 00:40:53 -0800 From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16896.37397.804541.303224@casey.transmeta.com> Date: Wed, 02 Feb 2005 08:41:00 -0000 To: Jim Blandy Cc: sid@sources.redhat.com, cgen@sources.redhat.com Subject: sid cgen cpus broken by absence of pic libiberty In-Reply-To: References: X-SW-Source: 2005-q1/txt/msg00010.txt.bz2 Jim Blandy writes: > *************** cgen_parse_keyword (CGEN_CPU_DESC cd ATT > *** 216,222 **** > /* Allow letters, digits, and any special characters. */ > while (((p - start) < (int) sizeof (buf)) > && *p > ! && (ISALNUM (*p) > || *p == '_' > || strchr (keyword_table->nonalpha_chars, *p))) > ++p; > --- 216,224 ---- > /* Allow letters, digits, and any special characters. */ > while (((p - start) < (int) sizeof (buf)) > && *p > ! && (('a' <= *p && *p <= 'z') > ! || ('A' <= *p && *p <= 'Z') > ! || ('0' <= *p && *p <= '9') > || *p == '_' > || strchr (keyword_table->nonalpha_chars, *p))) > ++p; > > Does that sound reasonable (well, reasonable with a clothespin on the > nose) to folks? Well, I'd still tuck the code away in macro or whatever. Or, use just plain ctype. This is just one example so who knows what libiberty actually brings to the party in all the affected cases though. Seems pretty sad though, eh? Maybe the thing to do is create one's own mini-libiberty that one controls and so isn't sacked with the politics or whatever of binutils. Keeping the naming close to libiberty would allow an easier transition back to libiberty if such a day arrives.