From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11854 invoked by alias); 29 May 2002 15:53:11 -0000 Mailing-List: contact sid-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: sid-owner@sources.redhat.com Received: (qmail 11799 invoked from network); 29 May 2002 15:53:02 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 29 May 2002 15:53:02 -0000 Received: from toenail.toronto.redhat.com (unknown [172.16.14.211]) by touchme.toronto.redhat.com (Postfix) with ESMTP id AE8DDB883E; Wed, 29 May 2002 11:53:01 -0400 (EDT) Received: (from fche@localhost) by toenail.toronto.redhat.com (8.11.6/8.11.6) id g4TFr1O19823; Wed, 29 May 2002 11:53:01 -0400 Date: Wed, 29 May 2002 08:53:00 -0000 From: "Frank Ch. Eigler" To: Ben Elliston Cc: sid@sources.redhat.com Subject: Re: CPU disassembler-memory accessor Message-ID: <20020529115301.C17962@redhat.com> References: <15604.59813.750421.114817@tooth.toronto.redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="sHrvAb52M6C8blB9" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <15604.59813.750421.114817@tooth.toronto.redhat.com>; from bje@redhat.com on Wed, May 29, 2002 at 10:45:57AM -0400 X-SW-Source: 2002-q2/txt/msg00024.txt.bz2 --sHrvAb52M6C8blB9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 568 Hi - bje wrote: > [...] > The following patch adds a third accessor to CPUs for the purpose of > providing the disassembler with access to the instruction memory > without causing undesirable side effects in the memory hierarchy. > [...] Thanks. > [...] Any comments? Yes, just one. The read_disasm_memory_1 function is methinks overengineered. It doesn't need to throw exceptions, nor handle accesses of other sizes. Actually, why not just do a direct sid::bus-level read() on the accessor and do away with the read_disasm_memory* thingie altogether? - FChE --sHrvAb52M6C8blB9 Content-Type: application/pgp-signature Content-Disposition: inline Content-length: 232 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE89PlcVZbdDOm/ZT0RAirNAJ9VoEvPkNO1TRJnvBzfaPujTJWaBgCdFD9n C81g6yGDjB5wozDt2w9A3yM= =dcMJ -----END PGP SIGNATURE----- --sHrvAb52M6C8blB9--