From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sid-return-624-listarch-sid=sources.redhat.com@sources.redhat.com>
Received: (qmail 3381 invoked by alias); 1 Jun 2003 14:32:53 -0000
Mailing-List: contact sid-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:sid-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/sid/>
List-Post: <mailto:sid@sources.redhat.com>
List-Help: <mailto:sid-help@sources.redhat.com>, <http://sources.redhat.com/lists.html#faqs>
Sender: sid-owner@sources.redhat.com
Received: (qmail 3068 invoked from network); 1 Jun 2003 14:32:42 -0000
Received: from unknown (HELO touchme.toronto.redhat.com) (207.219.125.105)
  by sources.redhat.com with SMTP; 1 Jun 2003 14:32:42 -0000
Received: from tooth.toronto.redhat.com (tooth.toronto.redhat.com [172.16.14.29])
	by touchme.toronto.redhat.com (Postfix) with ESMTP
	id 118F7800025; Sun,  1 Jun 2003 10:32:41 -0400 (EDT)
Received: from tooth.toronto.redhat.com (IDENT:AmEBrB7BWa2VW5+zGnFPRamHNy9IYyKg@localhost [127.0.0.1])
	by tooth.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id h51EWeVm016444;
	Sun, 1 Jun 2003 10:32:40 -0400
Received: (from fche@localhost)
	by tooth.toronto.redhat.com (8.12.8/8.12.8/Submit) id h51EWeAV016416;
	Sun, 1 Jun 2003 10:32:40 -0400
Date: Sun, 01 Jun 2003 14:32:00 -0000
From: "Frank Ch. Eigler" <fche@redhat.com>
To: Dave Brolley <brolley@redhat.com>
Cc: sid@sources.redhat.com
Subject: Re: [patch] Add Logging Support for SID Components
Message-ID: <20030601143239.GA31953@redhat.com>
References: <3ED7CCCB.4070004@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3ED7CCCB.4070004@redhat.com>
User-Agent: Mutt/1.4.1i
X-SW-Source: 2003-q2/txt/msg00040.txt.bz2

Hi -

> The attached patch adds logging support for sid components in 3 stages:
> [...]

Looks fine - good use of virtual inheritance.  A few minor things
I might have done differently:

- make a new component type for named file I/O, instead of
  changing sid-io-stdio; after all, stdio is bidirectional,
  meant to be interactive
- think of some other way to call stdout than "*"
- make logging output buffering dependent on an attribute (set as the last
  gasp of configuration) instead of pin-connectedness
- having a C++ flavour API (instead of printf()) for the logging function


- FChE