From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25200 invoked by alias); 9 Jun 2003 14:50:03 -0000 Mailing-List: contact sid-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: sid-owner@sources.redhat.com Received: (qmail 25014 invoked from network); 9 Jun 2003 14:49:59 -0000 Received: from unknown (HELO toenail.toronto.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 9 Jun 2003 14:49:59 -0000 Received: from toenail.toronto.redhat.com (localhost [127.0.0.1]) by toenail.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id h59Enwir023866; Mon, 9 Jun 2003 10:49:58 -0400 Received: (from fche@localhost) by toenail.toronto.redhat.com (8.12.8/8.12.8/Submit) id h59EnwmM023864; Mon, 9 Jun 2003 10:49:58 -0400 Date: Mon, 09 Jun 2003 14:50:00 -0000 From: "Frank Ch. Eigler" To: Dave Brolley Cc: sid@sources.redhat.com Subject: Re: [patch] Add Logging Support for SID Components Message-ID: <20030609144958.GB23478@redhat.com> References: <3ED7CCCB.4070004@redhat.com> <20030601143239.GA31953@redhat.com> <3EE49705.8000802@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="k1lZvvs/B4yU6o8G" Content-Disposition: inline In-Reply-To: <3EE49705.8000802@redhat.com> User-Agent: Mutt/1.4.1i X-SW-Source: 2003-q2/txt/msg00045.txt.bz2 --k1lZvvs/B4yU6o8G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 625 Hi - > This new patch replaces the previous one and addresses some of the=20 > concerns below.... Addressing my suggestions was not intended as a prerequisite for committing your previous version. The new version seems to have at least one actual problem though: the way that the buffer array is managed. Its allocation/deallocation strategy should be consistent (probably "new char[]" and "delete[] char") regardless of the availability of the various *sprintf variants. It should probably not even be in #if/#endif markers. The new code appears to be able to hit free() even though malloc() was never called. - FChE --k1lZvvs/B4yU6o8G Content-Type: application/pgp-signature Content-Disposition: inline Content-length: 189 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (GNU/Linux) iD8DBQE+5J6WVZbdDOm/ZT0RApzxAJ9XAgnC4pTa8F2j/wxrXrbi4D/IOQCfd3Mt KYyUpx9iPRznOn+ntyXEkZU= =fyEu -----END PGP SIGNATURE----- --k1lZvvs/B4yU6o8G--