From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sid-return-664-listarch-sid=sources.redhat.com@sources.redhat.com>
Received: (qmail 13271 invoked by alias); 29 Aug 2003 16:16:03 -0000
Mailing-List: contact sid-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:sid-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/sid/>
List-Post: <mailto:sid@sources.redhat.com>
List-Help: <mailto:sid-help@sources.redhat.com>, <http://sources.redhat.com/lists.html#faqs>
Sender: sid-owner@sources.redhat.com
Received: (qmail 13263 invoked from network); 29 Aug 2003 16:16:02 -0000
Received: from unknown (HELO touchme.toronto.redhat.com) (207.219.125.105)
  by sources.redhat.com with SMTP; 29 Aug 2003 16:16:02 -0000
Received: from toenail.toronto.redhat.com (toenail.toronto.redhat.com [172.16.14.211])
	by touchme.toronto.redhat.com (Postfix) with ESMTP
	id A85C180033C; Fri, 29 Aug 2003 12:16:01 -0400 (EDT)
Received: from toenail.toronto.redhat.com (IDENT:fche@localhost [127.0.0.1])
	by toenail.toronto.redhat.com (8.12.8/8.12.5) with ESMTP id h7TGG1i0032462;
	Fri, 29 Aug 2003 12:16:01 -0400
Received: (from fche@localhost)
	by toenail.toronto.redhat.com (8.12.8/8.12.8/Submit) id h7TGG1LP032460;
	Fri, 29 Aug 2003 12:16:01 -0400
Date: Fri, 29 Aug 2003 16:16:00 -0000
From: "Frank Ch. Eigler" <fche@redhat.com>
To: Dave Brolley <brolley@redhat.com>
Cc: sid@sources.redhat.com
Subject: Re: [patch][rfa] Add "active" pin to sid-sched
Message-ID: <20030829161600.GA32244@redhat.com>
References: <3F4F7AE9.10906@redhat.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="HcAYCG3uE/tztfnV"
Content-Disposition: inline
In-Reply-To: <3F4F7AE9.10906@redhat.com>
User-Agent: Mutt/1.4.1i
X-SW-Source: 2003-q3/txt/msg00019.txt.bz2


--HcAYCG3uE/tztfnV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-length: 544

Hi -

> [...]
> OK to commit?

Looks fine to commit, though please consider not using a new
"active_p" member variable in order to send edges on the active
pin.  This can be done by replacing ...

> + 	  // Drive the active pin if the threshold has been crossed.
> + 	  if (UNLIKELY(! this->active_p))
> + 	    {
> + 	      this->active_pin.drive (1);
> + 	      this->active_p =3D true;
> + 	    }
> +=20

with
	  if (this->active_pin.sense() !=3D 1)
	    this->active_pin->drive(1);

and a corresponding change for the 0 transition.


- FChE

--HcAYCG3uE/tztfnV
Content-Type: application/pgp-signature
Content-Disposition: inline
Content-length: 189

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE/T3xAVZbdDOm/ZT0RAjwoAJ9XUJtlJ2eIBaU223dw8VaukVF0jQCeJ3Ys
47ZtwQ4CmtdByIe/OpP8wzg=
=bqZ2
-----END PGP SIGNATURE-----

--HcAYCG3uE/tztfnV--