public inbox for sid@sourceware.org
 help / color / mirror / Atom feed
* [patch][rfa] typedef of 'bool' in /usr/include/curses.h on Solaris
@ 2007-01-03 20:31 Dave Brolley
  2007-01-03 21:17 ` Frank Ch. Eigler
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Brolley @ 2007-01-03 20:31 UTC (permalink / raw)
  To: sid

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

Hi,

/usr/include/curses.h on some Solaris platforms defines a typedef of 
'bool', even for C++ compiles unless the macro _BOOL is defined.

Is this patch OK to commit?

Dave


[-- Attachment #2: lcd.ChangeLog --]
[-- Type: text/plain, Size: 104 bytes --]

2006-12-07  Dave Brolley  <brolley@redhat.com>

	* lcd-char-display.cxx (_BOOL): New macro definition.


[-- Attachment #3: lcd.patch.txt --]
[-- Type: text/plain, Size: 684 bytes --]

Index: sid/component/lcd/lcd-char-display.cxx
===================================================================
RCS file: /cvs/src/src/sid/component/lcd/lcd-char-display.cxx,v
retrieving revision 1.7
diff -c -p -r1.7 lcd-char-display.cxx
*** sid/component/lcd/lcd-char-display.cxx	1 Mar 2006 21:07:00 -0000	1.7
--- sid/component/lcd/lcd-char-display.cxx	3 Jan 2007 20:28:03 -0000
***************
*** 15,20 ****
--- 15,23 ----
  #include <sidwatchutil.h>
  
  #ifdef HAVE__USR_INCLUDE_CURSES_H
+ // The following macro definition prevents curses.h from providing a typedef
+ // for bool on Solaris.
+ #define _BOOL 1
  #include "/usr/include/curses.h"
  #else
  #ifdef HAVE_CURSES_H

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch][rfa] typedef of 'bool' in /usr/include/curses.h on Solaris
  2007-01-03 20:31 [patch][rfa] typedef of 'bool' in /usr/include/curses.h on Solaris Dave Brolley
@ 2007-01-03 21:17 ` Frank Ch. Eigler
  0 siblings, 0 replies; 2+ messages in thread
From: Frank Ch. Eigler @ 2007-01-03 21:17 UTC (permalink / raw)
  To: Dave Brolley; +Cc: sid

Hi -

> Is this patch [#define _BOOK 1] OK to commit?

Sure, assuming it continues to build on a other oddball 
platforms like linux and cygwin. :-)

- FChE

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-01-03 21:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-03 20:31 [patch][rfa] typedef of 'bool' in /usr/include/curses.h on Solaris Dave Brolley
2007-01-03 21:17 ` Frank Ch. Eigler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).