From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12940 invoked by alias); 13 Nov 2008 16:37:04 -0000 Received: (qmail 12820 invoked by uid 22791); 13 Nov 2008 16:37:03 -0000 X-Spam-Check-By: sourceware.org Received: from ey-out-1920.google.com (HELO ey-out-1920.google.com) (74.125.78.150) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 13 Nov 2008 16:36:14 +0000 Received: by ey-out-1920.google.com with SMTP id 21so389143eyc.26 for ; Thu, 13 Nov 2008 08:36:11 -0800 (PST) Received: by 10.210.34.2 with SMTP id h2mr8461399ebh.123.1226594171378; Thu, 13 Nov 2008 08:36:11 -0800 (PST) Received: from ?192.168.0.108? (85-250-165-209.bb.netvision.net.il [85.250.165.209]) by mx.google.com with ESMTPS id 23sm4918510eya.7.2008.11.13.08.36.10 (version=SSLv3 cipher=RC4-MD5); Thu, 13 Nov 2008 08:36:10 -0800 (PST) From: Alon Bar-Lev To: sid@sources.redhat.com Subject: Re: [PATCH] sid/component/tcl fails to compile using internal tcl at binutils checkouts Date: Thu, 13 Nov 2008 16:37:00 -0000 User-Agent: KMail/1.9.9 References: <200811062132.11967.alon.barlev@gmail.com> In-Reply-To: <200811062132.11967.alon.barlev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200811131836.08501.alon.barlev@gmail.com> Mailing-List: contact sid-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: sid-owner@sourceware.org X-SW-Source: 2008-q4/txt/msg00007.txt.bz2 Anyone? On Thursday 06 November 2008, Alon Bar-Lev wrote: > > Hello, > > I initially reported this issue at binutils bugzilla [1]. > > I was referred to this list. > > The build environment has the capacity to use in-tree tcl. > > The sid/component/tcl is able to use this tcl, it does this by modifying the > CPPFLAGS in its autoconf. > > The problem is that the outer build environment overrides the CPPFLAGS with > something else and put it into the environment, so when the sid/component/tcl > Makefile is evaluated its CPPFLAGS is ignored. > > Attached a simple fix for this issue, using the INCLUDE variable. > > Regards, > Alon Bar-Lev. > > [1] http://sourceware.org/bugzilla/show_bug.cgi?id=6987 > > --- > > Index: sid/component/tcl/Makefile.am > =================================================================== > RCS file: /cvs/src/src/sid/component/tcl/Makefile.am,v > retrieving revision 1.5 > diff -u -B -r1.5 Makefile.am > --- sid/component/tcl/Makefile.am 4 Aug 2001 11:32:17 -0000 1.5 > +++ sid/component/tcl/Makefile.am 25 Oct 2008 22:29:30 -0000 > @@ -5,7 +5,7 @@ > > pkglib_LTLIBRARIES = libtclapi.la > > -INCLUDES = -I. -I../../include -I$(srcdir)/../../include > +INCLUDES = -I. -I../../include -I$(srcdir)/../../include $(EXTRA_INCLUDES) > > pkgdata_DATA = sid-control-tksm.tk hw-visual-probe-bus.blt bridge-tcl.tcl bridge-tk.tk bridge-blt.blt bridge-tcl.txt sid-api-trace.tcl hw-visual-probe-pin.tk > noinst_DATA = tester.tcl > Index: sid/component/tcl/configure.in > =================================================================== > RCS file: /cvs/src/src/sid/component/tcl/configure.in,v > retrieving revision 1.4 > diff -u -B -r1.4 configure.in > --- sid/component/tcl/configure.in 6 Feb 2003 20:27:37 -0000 1.4 > +++ sid/component/tcl/configure.in 25 Oct 2008 22:30:26 -0000 > @@ -64,7 +64,8 @@ > > > > -CPPFLAGS="$CPPFLAGS $with_tcl_include $with_tk_include $with_blt_include" > +EXTRA_INCLUDES="$with_tcl_include $with_tk_include $with_blt_include" > +AC_SUBST(EXTRA_INCLUDES) > > case "$host" in > >