Re: sid build issues

["Frank Ch. Eigler" <fche@redhat.com>]

Hi -

> A few things show up:
> 1) I've see weird, not easily reproducible failures of
>   make -jN
> at least with --enable-maintainer-mode.  Does anybody use it, is it
> supposed to work?  Are people aware of the issues, or should I report
> them?

I don't recall specific problems there.  I appreciate you trying to
work through them.


> 2) Within sid, the link fails on x86_64 if I use neither --enable-shared
> nor --disable-shared: [...]

> I'm unsure as to the Right Way[tm] to fix this: sid/configure.in checks
> whether $enable_shared was set to no, or checks whether
> $ac_cv_libstdcxx_shared is != yes.  [...]

We'd like --enable-shared by default.


> 3) I see a few (thousand) warnings of the form:
> | ../../../../../src/sid/component/cgen-cpu/sh/sh5-compact-decode.cxx:221: warning: deprecated conversion from string constant to 'char*'

> in several sid source files.  Is there interest in fixing them, or
> adding whatever command line argument make g++ permissive enough, to the
> compile command lines?

These files were generated by cgen.  An eyeballing of the sources
indicates that we have "const char*"s where they should be, so it
should work.  Perhaps cgen should spit out char[]'s instead for those
struct fields.


> 4) sid has its own config/ directory in which it stores versions of
> libtool.m4, ltmain.sh and other Autoconf macro files and helper scripts
> different from those used in the rest of src.  Is that desirable?  [...]

It used to be, back when cygwin's libtool was iffy.

> If you agree, then I'd work on a patch removing the duplicate files from
> sid/config, and adding the necessary includes for src/ and src/config/
> directories.

That would be great.


> 5) When building with --enable-maintainer-mode, and xsltproc 1.1.24
> installed, I get lots of ignored errors (one per xml file) of the form
> 
> | xsltproc --output hw-visual-lcd.html ../../../../src/sid/component/lcd/../component_html.xsl ../../../../src/sid/component/lcd/hw-visual-lcd.xml
> | runtime error: file ../../../../src/sid/component/lcd/../component_html.xsl line 21 element param
> | Unexpected XSLT element 'param'.
> | runtime error: file ../../../../src/sid/component/lcd/../component_html.xsl line 22 element choose
> | Variable 'body' has not been declared.
> | xmlXPathCompOpEval: parameter error
> | make[6]: *** [hw-visual-lcd.html] Error 10
> | rm hw-visual-lcd.html
> 
> They somehow seem to be ignored by make however.

I'll try to beat some xml/xslt cobwebs out of my brain to figure out
which part of that pipeline is erroneous.


- FChE