From: Dave Brolley <brolley@redhat.com>
To: sid@sources.redhat.com
Subject: [patch][rfa]: SID mapper component - wordsize
Date: Thu, 13 Feb 2003 23:58:00 -0000 [thread overview]
Message-ID: <3E4C3122.5040409@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
Hi,
I ran across a problem with the scaling of the upper bound of a mapped
range when the wordsize feature is used. The specification
[4*1000-1010]
should allow access to the range 4000-4043, however, the upper bound is
simply being multiplied by the wordsize, resulting in an upper bound of
4040. If the mapper is accessed using wordsized elements, the problem
goes unnoticed, since the mapper does not check the ending address of
the range being accessed. However, if the mapper is accessed one byte at
a time (as GDB often does), the final 3 bytes are considered unmapped.
Attached is the patch which corrects this. OK to commit?
Dave
[-- Attachment #2: mapper-wordsize.patch.txt --]
[-- Type: text/plain, Size: 1511 bytes --]
Index: component/mapper/compMapper.cxx
===================================================================
RCS file: /cvs/src/src/sid/component/mapper/compMapper.cxx,v
retrieving revision 1.12
diff -c -p -r1.12 compMapper.cxx
*** component/mapper/compMapper.cxx 11 Nov 2002 22:28:28 -0000 1.12
--- component/mapper/compMapper.cxx 13 Feb 2003 23:49:05 -0000
***************
*** 1,6 ****
// compMapper.cxx - a bus mapper component. -*- C++ -*-
! // Copyright (C) 1999-2002 Red Hat.
// This file is part of SID and is licensed under the GPL.
// See the file COPYING.SID for conditions for redistribution.
--- 1,6 ----
// compMapper.cxx - a bus mapper component. -*- C++ -*-
! // Copyright (C) 1999-2003 Red Hat.
// This file is part of SID and is licensed under the GPL.
// See the file COPYING.SID for conditions for redistribution.
*************** generic_mapper::make_name_mapping (const
*** 774,780 ****
// scale all values by the word width
record.mapped_base *= record.bytes_per_word;
record.low *= record.bytes_per_word;
! record.high *= record.bytes_per_word;
record.stride *= record.bytes_per_word;
record.width *= record.bytes_per_word;
--- 774,780 ----
// scale all values by the word width
record.mapped_base *= record.bytes_per_word;
record.low *= record.bytes_per_word;
! record.high = (record.high + 1) * record.bytes_per_word - 1;
record.stride *= record.bytes_per_word;
record.width *= record.bytes_per_word;
next reply other threads:[~2003-02-13 23:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-13 23:58 Dave Brolley [this message]
2003-02-14 2:52 ` Ben Elliston
2003-02-14 19:09 ` Frank Ch. Eigler
2003-02-14 19:38 ` Dave Brolley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E4C3122.5040409@redhat.com \
--to=brolley@redhat.com \
--cc=sid@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).