From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24819 invoked by alias); 29 Aug 2003 19:44:22 -0000 Mailing-List: contact sid-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: sid-owner@sources.redhat.com Received: (qmail 24811 invoked from network); 29 Aug 2003 19:44:21 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 29 Aug 2003 19:44:21 -0000 Received: from redhat.com (vpn50-63.rdu.redhat.com [172.16.50.63]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 9865780033E; Fri, 29 Aug 2003 15:44:20 -0400 (EDT) Message-ID: <3F4FAD3C.3040003@redhat.com> Date: Fri, 29 Aug 2003 19:44:00 -0000 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20021216 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Frank Ch. Eigler" Cc: sid@sources.redhat.com Subject: Re: [patch][rfa] Add "active" pin to sid-sched References: <3F4F7AE9.10906@redhat.com> <20030829161600.GA32244@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-q3/txt/msg00020.txt.bz2 Frank Ch. Eigler wrote: >Looks fine to commit, though please consider not using a new >"active_p" member variable in order to send edges on the active >pin. This can be done by replacing ... > > > >>+ // Drive the active pin if the threshold has been crossed. >>+ if (UNLIKELY(! this->active_p)) >>+ { >>+ this->active_pin.drive (1); >>+ this->active_p = true; >>+ } >>+ >> >> > >with > if (this->active_pin.sense() != 1) > this->active_pin->drive(1); > >and a corresponding change for the 0 transition. > > This doesn't work because active_pin is an output_pin. Dave