public inbox for sid@sourceware.org
 help / color / mirror / Atom feed
From: Dave Brolley <brolley@redhat.com>
To: sid@sources.redhat.com
Subject: [patch] logger::delete_saved_messages
Date: Wed, 17 Dec 2003 19:58:00 -0000	[thread overview]
Message-ID: <3FE0B55A.2040403@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

This corrects the clearing of saved_messages and saved_levels. The 
previous code was just plain incorrect and caused memory access problems 
on some platforms.

Dave


[-- Attachment #2: logger.ChangeLog --]
[-- Type: text/plain, Size: 111 bytes --]

2003-12-17  Dave Brolley  <brolley@redhat.com>

	* sidmiscutil.h (delete_saved_messages): Use 'clear' method.


[-- Attachment #3: logger.patch.txt --]
[-- Type: text/plain, Size: 1177 bytes --]

Index: sid/include/sidmiscutil.h
===================================================================
RCS file: /cvs/src/src/sid/include/sidmiscutil.h,v
retrieving revision 1.7
retrieving revision 1.8
diff -c -p -r1.7 -r1.8
*** sid/include/sidmiscutil.h	21 Oct 2003 21:38:24 -0000	1.7
--- sid/include/sidmiscutil.h	17 Dec 2003 19:51:02 -0000	1.8
***************
*** 1,6 ****
  // sidmiscutil.h - Useful utility classes.  -*- C++ -*-
  
! // Copyright (C) 1999-2002 Red Hat.
  // This file is part of SID and is licensed under the GPL.
  // See the file COPYING.SID for conditions for redistribution.
  
--- 1,6 ----
  // sidmiscutil.h - Useful utility classes.  -*- C++ -*-
  
! // Copyright (C) 1999-2003 Red Hat.
  // This file is part of SID and is licensed under the GPL.
  // See the file COPYING.SID for conditions for redistribution.
  
*************** namespace sidutil
*** 526,532 ****
    public:
      void delete_saved_messages ()
      {
!       saved_messages.erase (saved_messages.end ());
      }
    };
  
--- 526,533 ----
    public:
      void delete_saved_messages ()
      {
!       saved_messages.clear ();
!       saved_levels.clear ();
      }
    };
  

             reply	other threads:[~2003-12-17 19:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-17 19:58 Dave Brolley [this message]
2003-12-17 20:08 ` Dave Brolley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FE0B55A.2040403@redhat.com \
    --to=brolley@redhat.com \
    --cc=sid@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).