From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24772 invoked by alias); 13 Feb 2004 15:17:23 -0000 Mailing-List: contact sid-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: sid-owner@sources.redhat.com Received: (qmail 24765 invoked from network); 13 Feb 2004 15:17:21 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 13 Feb 2004 15:17:21 -0000 Received: from redhat.com (vpn50-13.rdu.redhat.com [172.16.50.13]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 08C54800389; Fri, 13 Feb 2004 10:17:18 -0500 (EST) Message-ID: <402CEA85.9010109@redhat.com> Date: Fri, 13 Feb 2004 15:17:00 -0000 From: Dave Brolley User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 (ax) MIME-Version: 1.0 To: Ben Elliston Cc: sid@sources.redhat.com Subject: Re: [patch] ELF loader References: <402BE20E.2030804@redhat.com> <87r7wz65fw.fsf@wasabisystems.com> In-Reply-To: <87r7wz65fw.fsf@wasabisystems.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-q1/txt/msg00017.txt.bz2 Ben Elliston wrote: >Dave Brolley writes: > > > >>I'm committing the attached patch which requirks the ELF loader to >>correct the following problems: >> >> > >This looks mostly fine, however I have one question: where is the >dependency on libiberty introduced and can it be avoided? > > I used xrealloc to allocate loadAreas and textSections. It used to be an unchecked hard coded limit of 100 elements each. I figured that using libiberty was ok since it's already used by sid/component/cgen-cpu. That's where I got the Makefile.am changes. It could be avoided by using realloc and checking for failure. I guess failure would have to result in an abort? Dave