From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13271 invoked by alias); 22 Mar 2004 21:40:29 -0000 Mailing-List: contact sid-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: sid-owner@sources.redhat.com Received: (qmail 13257 invoked from network); 22 Mar 2004 21:40:28 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 22 Mar 2004 21:40:28 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i2MLeRWA019536; Mon, 22 Mar 2004 16:40:27 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i2MLeQM01696; Mon, 22 Mar 2004 16:40:26 -0500 Received: from redhat.com (IDENT:/VeMi6DYun+v3nkJfX2dqSl2AqSnwYI5@vpn50-12.rdu.redhat.com [172.16.50.12]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i2MLeOR10613; Mon, 22 Mar 2004 13:40:24 -0800 Message-ID: <405F5D2E.6070008@redhat.com> Date: Mon, 22 Mar 2004 21:40:00 -0000 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20021216 MIME-Version: 1.0 To: Dave Brolley CC: sid@sources.redhat.com, cgen@sources.redhat.com Subject: Re: [patch][rfa] SID cpu tracing -- attempt #2 References: <405F3AB6.1020707@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-RedHat-Spam-Score: -4.9 X-SW-Source: 2004-q1/txt/msg00047.txt.bz2 Approved by fche and committed. Dave Brolley wrote: > Hi, > > Reponding to Frank's concerns about my previous patch, here is an > implementation along the lines he suggested. The idea is that each > CGEN 'set' handler and each component which is the target of a store > operation is responsible to annotating the cpu trace with the actual > value stored, if desired. In order to accomplish this, two changes > were necessary. > > 1) The tracing code generated by CGEN is now generated before the code > for the semantic operation. That way any annotation appears after the > original cpu trace. > > 2) basic_cpu now has a "trace" pin for use by other components. Each > value driven on the pin will be echoed as a character into the cpu's > trace_stream. This way annotation by other components are merged > properly with the cpu trace whether it be to cout or to a file. > > I've attached sid-trace-cgen.patch.txt which shows the CGEN changes > and a partial diff of the resulting changes to xstormy16-sem.cxx. I've > also attached sid-trace.patch.txt which shows the changes to basic_cpu. > > Tested on an internal port which requirs this functionality. > > OK to commit? > > Dave