From: Dave Brolley <brolley@redhat.com>
To: Dave Brolley <brolley@redhat.com>
Cc: sid@sources.redhat.com
Subject: Re: [patch][rfa] Multi core debugging with GDB
Date: Mon, 22 Mar 2004 21:45:00 -0000 [thread overview]
Message-ID: <405F5E40.2040600@redhat.com> (raw)
In-Reply-To: <405F5E0A.4000502@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1585 bytes --]
And here's the modified patch for socketio.cxx
Dave Brolley wrote:
> Approved by fche and committed with the attached modification to
> ensure that all data gets flushed.
>
> Dave Brolley wrote:
>
>> Hi,
>>
>> Debugging multiple cores with multiple instances of GDB within a
>> simulation is currently possible by specifying a separate --gdb
>> option after each --board and specifying a different port for each
>> GDB instance. The simulation ends (as it does without GDB) when the
>> first core exits. However, the other GDB instances all report
>> "Watchdog expired. Target disconnected". This was because of three
>> problems:
>>
>> 1) The "enabled?", "enable-threshold", "yield-host-time?" and
>> "yield-host-time-threshold" of the host scheduler were not being set.
>> This caused the host scheduler to yield host time after the first GDB
>> stub exited.
>>
>> 2) The other GDB stubs were not properly notifying their GDB clients
>> that they were exiting
>>
>> 3) Even after proper notfication and yielding were implemented, the
>> packets never reached their GDB clients because their socket
>> components were never polled again which was because the host
>> scheduler was never advanced again which was because the whole shut
>> down process was initiated when the first GDB stub drove main's
>> "stop!" pin. This problem is corrected by having the sockets do one
>> final transmit when their "fini" pins are driven by shutdown-sequence.
>>
>> The result is an orderly shutdown of the GDB stubs and their clients.
>>
>> OK to commit?
>>
>> Dave
>
>
>
>
[-- Attachment #2: socket-flush.patch.txt --]
[-- Type: text/plain, Size: 1244 bytes --]
Index: sid/component/consoles/socketio.cxx
===================================================================
RCS file: /cvs/src/src/sid/component/consoles/socketio.cxx,v
retrieving revision 1.5
retrieving revision 1.6
diff -c -p -r1.5 -r1.6
*** sid/component/consoles/socketio.cxx 4 Mar 2002 20:38:56 -0000 1.5
--- sid/component/consoles/socketio.cxx 22 Mar 2004 21:26:44 -0000 1.6
***************
*** 1,7 ****
// socketio.cxx - A console that uses a socket to do its I/O.
// -*- C++ -*-
! // Copyright (C) 1999, 2000, 2002 Red Hat.
// This file is part of SID and is licensed under the GPL.
// See the file COPYING.SID for conditions for redistribution.
--- 1,7 ----
// socketio.cxx - A console that uses a socket to do its I/O.
// -*- C++ -*-
! // Copyright (C) 1999-2002, 2004 Red Hat.
// This file is part of SID and is licensed under the GPL.
// See the file COPYING.SID for conditions for redistribution.
*************** void
*** 297,302 ****
--- 297,306 ----
socketio::fini_handler (host_int_4)
{
this->poll_control.cancel ();
+
+ // Flush out any remaining data
+ while (this->connected_p && this->out_buffer.length() != 0)
+ this->poll_transmit ();
if (this->connected_p)
{
prev parent reply other threads:[~2004-03-22 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-22 19:37 Dave Brolley
2004-03-22 19:56 ` Frank Ch. Eigler
2004-03-22 21:44 ` Dave Brolley
2004-03-22 21:45 ` Dave Brolley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=405F5E40.2040600@redhat.com \
--to=brolley@redhat.com \
--cc=sid@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).