From: Dave Brolley <brolley@redhat.com>
To: sid@sources.redhat.com
Subject: [patch] Checking for valid cache lines
Date: Tue, 20 Jul 2004 17:17:00 -0000 [thread overview]
Message-ID: <40FD5327.1040600@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
Hi,
I've committed the attached patch which adds some checks to make sure
cache lines are valid before they are returned as a hit or flushed. The
patch also move a call to 'addr_to_tag' past a possible return point to
the place where the result is first needed.
Dave
[-- Attachment #2: sid-cache.ChangeLog --]
[-- Type: text/plain, Size: 345 bytes --]
2004-07-20 Dave Brolley <brolley@redhat.com>
* cacheutil.cxx (find): Make sure cache line is valid before returning
it.
* cache.cxx (write_any): Move call to addr_to_tag to a later point when
the result is actually needed. Make sure cache line is valid before
flushing it.
(read_any): Make sure cache line is valid before flushing it.
[-- Attachment #3: sid-cache.patch.txt --]
[-- Type: text/plain, Size: 2908 bytes --]
Index: sid/component/cache/cache.cxx
===================================================================
RCS file: /cvs/src/src/sid/component/cache/cache.cxx,v
retrieving revision 1.18
diff -c -p -r1.18 cache.cxx
*** sid/component/cache/cache.cxx 1 Jul 2004 16:55:09 -0000 1.18
--- sid/component/cache/cache.cxx 20 Jul 2004 17:07:13 -0000
*************** cache_component::write_any (host_int_4 a
*** 180,186 ****
if (LIKELY (collect_p))
stats.writes++;
- cache_tag tag = acache.addr_to_tag (addr);
if (UNLIKELY (addr % sizeof (data) != 0))
{
if (LIKELY (collect_p))
--- 180,185 ----
*************** cache_component::write_any (host_int_4 a
*** 191,196 ****
--- 190,196 ----
if (UNLIKELY (addr % line_size + sizeof (data) > line_size))
return bus::misaligned;
+ cache_tag tag = acache.addr_to_tag (addr);
cache_line* line = acache.find (tag);
if (LIKELY (line))
{
*************** cache_component::write_any (host_int_4 a
*** 215,221 ****
if (! write_through_p)
{
! if (expelled_line->dirty_p ())
{
// flush a dirty line being replaced
if ((st = write_line (*expelled_line)) != bus::ok)
--- 215,221 ----
if (! write_through_p)
{
! if (expelled_line->valid_p () && expelled_line->dirty_p ())
{
// flush a dirty line being replaced
if ((st = write_line (*expelled_line)) != bus::ok)
*************** cache_component::read_any (host_int_4 ad
*** 291,297 ****
cache_line *expelled_line = acache.expell_line (tag);
assert (expelled_line);
! if (expelled_line->dirty_p ())
{
// flush a dirty line being replaced
if ((st = write_line (*expelled_line)) != bus::ok)
--- 291,297 ----
cache_line *expelled_line = acache.expell_line (tag);
assert (expelled_line);
! if (expelled_line->valid_p () && expelled_line->dirty_p ())
{
// flush a dirty line being replaced
if ((st = write_line (*expelled_line)) != bus::ok)
Index: sid/component/cache/cacheutil.cxx
===================================================================
RCS file: /cvs/src/src/sid/component/cache/cacheutil.cxx,v
retrieving revision 1.9
diff -c -p -r1.9 cacheutil.cxx
*** sid/component/cache/cacheutil.cxx 10 May 2004 21:51:10 -0000 1.9
--- sid/component/cache/cacheutil.cxx 20 Jul 2004 17:07:13 -0000
*************** cache_set::find (const cache_tag& tag)
*** 173,179 ****
// order of associativity will be small.
for (const_iterator_t it = lines.begin (); it != lines.end (); it++)
! if (tag == *(*it))
{
replacer.update (*this, *(*it));
return *it;
--- 173,179 ----
// order of associativity will be small.
for (const_iterator_t it = lines.begin (); it != lines.end (); it++)
! if (tag == *(*it) && (*it)->valid_p ())
{
replacer.update (*this, *(*it));
return *it;
reply other threads:[~2004-07-20 17:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40FD5327.1040600@redhat.com \
--to=brolley@redhat.com \
--cc=sid@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).