From: Dave Brolley <brolley@redhat.com>
To: Michael Torbett <mtorbett@savaJe.com>
Cc: sid@sources.redhat.com
Subject: Re: recent CVS snapshots of SID are broken
Date: Thu, 30 Jun 2005 16:04:00 -0000 [thread overview]
Message-ID: <42C417EE.2060204@redhat.com> (raw)
In-Reply-To: <42C30AC4.4060208@savaje.com>
In each case, the original definition and the (supposed) multiple
definition are on the same line and source file.
The problem appears to be that sid-bochs-memory.cc is listed twice in
libmemory_la_SOURCES in sid/component/bochs/cpu/memory/Makefile.am. I've
commited thet following patch.
Dave
2005-06-30 Dave Brolley <brolley@redhat.com>
* cpu/memory/Makefile.am (libmemory_la_SOURCES): Remove duplicate
sid-bochs-memory.cc
* cpu/memory/Makefile.in: Regenerate.
Index: Makefile.am
===================================================================
RCS file: /cvs/src/src/sid/component/bochs/cpu/memory/Makefile.am,v
retrieving revision 1.1
retrieving revision 1.2
diff -c -p -r1.1 -r1.2
*** Makefile.am 15 Feb 2002 01:18:46 -0000 1.1
--- Makefile.am 30 Jun 2005 16:00:03 -0000 1.2
*************** INCLUDES = -I$(top_builddir)/../../inclu
*** 6,11 ****
noinst_LTLIBRARIES = libmemory.la
! libmemory_la_SOURCES = sid-bochs-memory.cc sid-bochs-memory.cc
libmemory_la_LDFLAGS = -no-undefined
--- 6,11 ----
noinst_LTLIBRARIES = libmemory.la
! libmemory_la_SOURCES = sid-bochs-memory.cc
libmemory_la_LDFLAGS = -no-undefined
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/sid/component/bochs/cpu/memory/Makefile.in,v
retrieving revision 1.3
retrieving revision 1.4
diff -c -p -r1.3 -r1.4
*** Makefile.in 4 Jun 2005 03:22:58 -0000 1.3
--- Makefile.in 30 Jun 2005 16:00:03 -0000 1.4
*************** CONFIG_HEADER = $(top_builddir)/config.h
*** 49,55 ****
CONFIG_CLEAN_FILES =
LTLIBRARIES = $(noinst_LTLIBRARIES)
libmemory_la_LIBADD =
! am_libmemory_la_OBJECTS = sid-bochs-memory.lo sid-bochs-memory.lo
libmemory_la_OBJECTS = $(am_libmemory_la_OBJECTS)
DEFAULT_INCLUDES = -I. -I$(srcdir) -I$(top_builddir)
depcomp = $(SHELL) $(top_srcdir)/../../config/depcomp
--- 49,55 ----
CONFIG_CLEAN_FILES =
LTLIBRARIES = $(noinst_LTLIBRARIES)
libmemory_la_LIBADD =
! am_libmemory_la_OBJECTS = sid-bochs-memory.lo
libmemory_la_OBJECTS = $(am_libmemory_la_OBJECTS)
DEFAULT_INCLUDES = -I. -I$(srcdir) -I$(top_builddir)
depcomp = $(SHELL) $(top_srcdir)/../../config/depcomp
*************** target_alias = @target_alias@
*** 240,246 ****
AUTOMAKE_OPTIONS = foreign
INCLUDES = -I$(top_builddir)/../../include -I$(srcdir) -I$(srcdir)/..
-I$(srcdir)/../.. -I$(srcdir)/../../../../include
noinst_LTLIBRARIES = libmemory.la
! libmemory_la_SOURCES = sid-bochs-memory.cc sid-bochs-memory.cc
libmemory_la_LDFLAGS = -no-undefined
all: all-am
--- 240,246 ----
AUTOMAKE_OPTIONS = foreign
INCLUDES = -I$(top_builddir)/../../include -I$(srcdir) -I$(srcdir)/..
-I$(srcdir)/../.. -I$(srcdir)/../../../../include
noinst_LTLIBRARIES = libmemory.la
! libmemory_la_SOURCES = sid-bochs-memory.cc
libmemory_la_LDFLAGS = -no-undefined
all: all-am
prev parent reply other threads:[~2005-06-30 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-29 20:56 Michael Torbett
2005-06-30 16:04 ` Dave Brolley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42C417EE.2060204@redhat.com \
--to=brolley@redhat.com \
--cc=mtorbett@savaJe.com \
--cc=sid@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).