From: Dave Brolley <brolley@redhat.com>
To: Dave Brolley <brolley@redhat.com>
Cc: cgen@sources.redhat.com, binutils@sources.redhat.com,
gdb-patches@sources.redhat.com, sid@sources.redhat.com
Subject: Re: [patch][rfa] Representation of ISA Attribute in CGEN
Date: Fri, 28 Oct 2005 20:35:00 -0000 [thread overview]
Message-ID: <43628B86.20101@redhat.com> (raw)
In-Reply-To: <433319E3.9060307@redhat.com>
This patch has now been committed.....
Dave Brolley wrote:
> Hi,
>
> These changes have been in our local tree for a few years now and were
> developed for an internal port which requires *much* more than 32 ISAs
> or even 64 ISAs. These changes could be of benifit to others, so I
> would like to submit them for approval.
>
> Currently, ISA is represented as an integer, like all the other
> non-boolean attributes. It is a bit mask with each bit representing
> whether a particular ISA is supported. Our port requires that there be
> no fixed limit on the number of ISAs, and so, we developed an
> open-ended representation for a bitset using a bitstring and a length.
> It is called CGEN_BITSET and is declared in
> include/opcode/cgen-bitset.h and supported by several new functions in
> opcodes/cgen-opc.c. All manipulation of these bitsets is done using
> these functions which hide the internal representation. See
> cgen-bitset.h (attached) for a description of the implementation
>
> The patch has 3 parts:
> 1) Extension of CGEN_ATTR_VALUE_TYPE to be a union allowing the use of
> CGEN_BITSET as well as its supporting macros.
>
> 2) Changes to CGEN so that it generates code to correctly access and
> initialize the new definition of CGEN_ATTR_VALUE_TYPE and to use the
> proper cover functions when manipulating ISAs.
>
> 3) Changes to hand written portions of existing opcodes, sim and sid
> ports as in 2). Fortunately, the use of existing CGEN macros made
> these changes minimal.
>
> I have also included in the patch the regenerated source for the frv
> port so that you can see the effect on the generated code. None of the
> generated code for existing sid ports is affected.
>
> One natural extension of this work would be use the same
> representation for all bitset attributes in CGEN. I believe that MACH
> is the only other one at this time.
>
> Seeking comments and approval to commit.
>
> Thanks,
> Dave
>
prev parent reply other threads:[~2005-10-28 20:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-22 20:58 Dave Brolley
2005-10-28 20:35 ` Dave Brolley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43628B86.20101@redhat.com \
--to=brolley@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=cgen@sources.redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=sid@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).