public inbox for
 help / color / mirror / Atom feed
From: Dave Brolley <>
To: "Frank Ch. Eigler" <>
Subject: Re: [patch][rfa] --gprof Performance Improvement
Date: Mon, 26 Jun 2006 20:57:00 -0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Frank Ch. Eigler wrote:

>Nicely done, thanks.  (If backward compatibility was at all a concern,
>the gprof component could have a new "sample" pin that assumes the
>pin-based PC traffic, instead of changing the current interface.  But
>I agree that the old interface is not worth saving.)
>Was the string conversion stuff obvious in profiling output?
I don't know --- I took a more brute force approach, since I knew that 
the overhead was in the driving of the cpu's sample-gprof pin (the only 
effect of using --gprof). I first suspected overhead in the std::map 
used to collect the buckets, but that turned out to be small. I then 
tried the "local reference for this->stats[current_stats]" optimization 
and got the 3%. I then tried experimentally removing the collection of 
the data and found no improvement. That left the parsing of the 
attributes which, when experimentally removed, accounted for all of the 
nasty overhead.


  reply	other threads:[~2006-06-26 20:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-26 19:46 Dave Brolley
2006-06-26 19:57 ` Frank Ch. Eigler
2006-06-26 20:57   ` Dave Brolley [this message]
2006-06-26 21:18     ` Dave Brolley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).