public inbox for sid@sourceware.org
 help / color / mirror / Atom feed
From: Dave Brolley <brolley@redhat.com>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: cgen@sources.redhat.com, sid@sources.redhat.com
Subject: Re: [patch][rfa] Don't Generate Code to Support Unused Write Stacks
Date: Thu, 13 Jul 2006 18:43:00 -0000	[thread overview]
Message-ID: <44B69448.3020308@redhat.com> (raw)
In-Reply-To: <y0mmzbequl5.fsf@ton.toronto.redhat.com>

Frank Ch. Eigler wrote:

>brolley wrote:
>
>  
>
>>[...]
>>When generating write stacks and the supporting code in order to
>>suppor the (delay ...) rtl construct for SID, cgen currently generates
>>a write stack for all registers and memory modes regardless of whether
>>they are used or not. [...]
>>For the internal port for which performance was an issue, this yielded
>>an improvement of 17%. [...]
>>    
>>
>
>Sounds good.  I'm surprised though that your change should cause such
>a noticeable improvement.  It may be that the sid-side code to handle
>the write queue testing/iteration is rather deficient.  (Try adding
>some UNLIKELY markers to the CPU::writeback() function's while()
>conditions.)
>  
>
I think that the difference was 39 vs 2 write stacks to manage for this 
port.

Dave

  reply	other threads:[~2006-07-13 18:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-12 21:09 Dave Brolley
2006-07-12 21:53 ` SID for PowerPC Evgeny Belyanco
2006-07-13 19:10   ` Frank Ch. Eigler
2006-07-13 19:47     ` Re[2]: " Evgeny Belyanco
2006-07-13 20:12       ` Frank Ch. Eigler
2006-07-12 23:20 ` [patch][rfa] Don't Generate Code to Support Unused Write Stacks Frank Ch. Eigler
2006-07-13 18:43   ` Dave Brolley [this message]
2006-07-14 18:54     ` Dave Brolley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44B69448.3020308@redhat.com \
    --to=brolley@redhat.com \
    --cc=cgen@sources.redhat.com \
    --cc=fche@redhat.com \
    --cc=sid@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).