From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sid-return-1160-listarch-sid=sources.redhat.com@sourceware.org>
Received: (qmail 17996 invoked by alias); 14 Jul 2006 18:54:12 -0000
Received: (qmail 17978 invoked by uid 22791); 14 Jul 2006 18:54:11 -0000
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Jul 2006 18:54:05 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) 	by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k6EIs3OX020134; 	Fri, 14 Jul 2006 14:54:03 -0400
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) 	by int-mx1.corp.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k6EIs2fL028525; 	Fri, 14 Jul 2006 14:54:02 -0400
Received: from [172.16.50.154] (vpn50-154.rdu.redhat.com [172.16.50.154]) 	by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id k6EIrxHS004745; 	Fri, 14 Jul 2006 14:53:59 -0400
Message-ID: <44B7E849.70100@redhat.com>
Date: Fri, 14 Jul 2006 18:54:00 -0000
From: Dave Brolley <brolley@redhat.com>
User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050317)
MIME-Version: 1.0
To: Dave Brolley <brolley@redhat.com>
CC: "Frank Ch. Eigler" <fche@redhat.com>, cgen@sources.redhat.com,         sid@sources.redhat.com
Subject: Re: [patch][rfa] Don't Generate Code to Support Unused Write Stacks
References: <44B564FE.1030002@redhat.com> <y0mmzbequl5.fsf@ton.toronto.redhat.com> <44B69448.3020308@redhat.com>
In-Reply-To: <44B69448.3020308@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact sid-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:sid-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/sid/>
List-Post: <mailto:sid@sourceware.org>
List-Help: <mailto:sid-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: sid-owner@sourceware.org
X-SW-Source: 2006-q3/txt/msg00018.txt.bz2

Frank Ch. Eigler wrote:

>> Sounds good.  I'm surprised though that your change should cause such
>> a noticeable improvement.  It may be that the sid-side code to handle
>> the write queue testing/iteration is rather deficient.  (Try adding
>> some UNLIKELY markers to the CPU::writeback() function's while()
>> conditions.)
>
>
This patch has now been committed.

Dave