From: Dave Brolley <brolley@redhat.com>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: sid@sources.redhat.com
Subject: Re: Fwd: Regarding the sid simulator [patch][commit]
Date: Thu, 30 Nov 2006 18:52:00 -0000 [thread overview]
Message-ID: <456F284A.2070507@redhat.com> (raw)
In-Reply-To: <20061129213327.GJ8910@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 408 bytes --]
Frank Ch. Eigler wrote:
> The costs (compile time / object size) are of a different magnitude.
> We don't rip out unconfigured platforms out of configrun-sid.pl either
> - they just won't work. Plus, if you add the #if/#endif thing I
> mentioned, the costs of including a dummy shCfg.cxx are approximately
> zero.
>
>
As requested, I've removed the previous patch and committed this one
instead.
Dave
[-- Attachment #2: sh-config-1.ChangeLog --]
[-- Type: text/plain, Size: 407 bytes --]
2006-11-30 Dave Brolley <brolley@redhat.com>
* Makefile.am (TARGETCFGS): Revert previous changes. Add shCfg.cxx
unconditionally.
* Makefile.in: Regenerated.
* aclocal.m4: Regenerated.
* configure: Regenerated.
* shCfg.cxx: Protect the entire file with preprocessor conditional
compilation for sh or sh64.
2006-11-30 Dave Brolley <brolley@redhat.com>
* sidtargets.m4: Revert previous change.
[-- Attachment #3: sh-config-1.patch.txt --]
[-- Type: text/plain, Size: 1848 bytes --]
Index: sid/main/dynamic/Makefile.am
===================================================================
RCS file: /cvs/src/src/sid/main/dynamic/Makefile.am,v
retrieving revision 1.14
diff -c -p -r1.14 Makefile.am
*** sid/main/dynamic/Makefile.am 29 Nov 2006 21:18:30 -0000 1.14
--- sid/main/dynamic/Makefile.am 30 Nov 2006 18:36:14 -0000
*************** INCLUDES = -I. -I../../include -I$(srcdi
*** 7,13 ****
LIBIBERTY = -L../../../libiberty/pic -L../../../libiberty -liberty
bin_PROGRAMS = sid
! TARGETCFGS = ""
TARGETDEFINES =
if SIDTARGET_SH
--- 7,13 ----
LIBIBERTY = -L../../../libiberty/pic -L../../../libiberty -liberty
bin_PROGRAMS = sid
! TARGETCFGS = shCfg.cxx
TARGETDEFINES =
if SIDTARGET_SH
*************** endif
*** 16,24 ****
if SIDTARGET_SH64
TARGETDEFINES += -DSIDTARGET_SH64
endif
- if SIDTARGET_SH_OR_SH64
- TARGETCFGS += shCfg.cxx
- endif
# If sid is being compiled without shared library support, arrange to
# statically link in a bunch of component libraries using libtool's
--- 16,21 ----
Index: sid/main/dynamic/shCfg.cxx
===================================================================
RCS file: /cvs/src/src/sid/main/dynamic/shCfg.cxx,v
retrieving revision 1.1
diff -c -p -r1.1 shCfg.cxx
*** sid/main/dynamic/shCfg.cxx 18 Oct 2006 18:46:17 -0000 1.1
--- sid/main/dynamic/shCfg.cxx 30 Nov 2006 18:36:16 -0000
***************
*** 4,9 ****
--- 4,10 ----
// This file is part of SID and is licensed under the GPL.
// See the file COPYING.SID for conditions for redistribution.
+ #if defined (SIDTARGET_SH) || defined (SIDTARGET_SH64)
#include "shCfg.h"
*************** mk_sh5_64media (const string name, Sessi
*** 222,224 ****
--- 223,227 ----
return board;
}
#endif // defined (SIDTARGET_SH64)
+
+ #endif // defined (SIDTARGET_SH) || defined (SIDTARGET_SH64)
prev parent reply other threads:[~2006-11-30 18:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c1cd9c970611262354h2b5e928cib4ac5c7ee4390269@mail.gmail.com>
2006-11-27 13:03 ` Regarding the sid simulator Frank Ch. Eigler
[not found] ` <c1cd9c970611271523hd2e9721n6da6c054754e0976@mail.gmail.com>
[not found] ` <c1cd9c970611271531x37001d3k59da231d5c6a7506@mail.gmail.com>
2006-11-27 23:57 ` Fwd: " Frank Ch. Eigler
2006-11-28 7:48 ` Avinash Malik
2006-11-28 23:54 ` Frank Ch. Eigler
2006-11-29 21:20 ` Fwd: Regarding the sid simulator [patch][commit] Dave Brolley
2006-11-29 21:25 ` Frank Ch. Eigler
2006-11-29 21:30 ` Dave Brolley
2006-11-29 21:33 ` Frank Ch. Eigler
2006-11-30 18:52 ` Dave Brolley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456F284A.2070507@redhat.com \
--to=brolley@redhat.com \
--cc=fche@redhat.com \
--cc=sid@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).