From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11130 invoked by alias); 17 Jan 2007 20:57:08 -0000 Received: (qmail 11102 invoked by uid 22791); 17 Jan 2007 20:57:07 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 17 Jan 2007 20:57:01 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l0HKux0b013533 for ; Wed, 17 Jan 2007 15:56:59 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l0HKuwPZ010665 for ; Wed, 17 Jan 2007 15:56:59 -0500 Received: from [10.11.14.211] (vpn-14-211.rdu.redhat.com [10.11.14.211]) by potter.sfbay.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l0HKuuLN002574 for ; Wed, 17 Jan 2007 15:56:57 -0500 Message-ID: <45AE8D98.1000206@redhat.com> Date: Wed, 17 Jan 2007 20:57:00 -0000 From: Dave Brolley User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050317) MIME-Version: 1.0 To: sid@sources.redhat.com Subject: [patch][commit] ISO C++ Compliance Content-Type: multipart/mixed; boundary="------------090206010501060405080509" X-IsSubscribed: yes Mailing-List: contact sid-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: sid-owner@sourceware.org X-SW-Source: 2007-q1/txt/msg00005.txt.bz2 This is a multi-part message in MIME format. --------------090206010501060405080509 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 213 Hi, I've committed the attached patch which allows compilation with recent more strict ISO C++ compliance by gcc. The typedef is referenced by an inheriting class and, so, must be protected, not private. Dave --------------090206010501060405080509 Content-Type: text/plain; name="sid.iso.ChangeLog" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="sid.iso.ChangeLog" Content-length: 118 2007-01-17 Dave Brolley * sidbusutil.h (value_control_register::ValueType): Now protected. --------------090206010501060405080509 Content-Type: text/plain; name="sid.iso.patch.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="sid.iso.patch.txt" Content-length: 772 Index: sid/include/sidbusutil.h =================================================================== RCS file: /cvs/src/src/sid/include/sidbusutil.h,v retrieving revision 1.16 diff -c -p -r1.16 sidbusutil.h *** sid/include/sidbusutil.h 2 Aug 2005 18:53:10 -0000 1.16 --- sid/include/sidbusutil.h 11 Jan 2007 19:10:33 -0000 *************** namespace sidutil *** 730,736 **** template class value_control_register: public control_register { ! private: typedef typename DataType::value_type ValueType; public: --- 730,736 ---- template class value_control_register: public control_register { ! protected: typedef typename DataType::value_type ValueType; public: --------------090206010501060405080509--