From: Dave Brolley <brolley@redhat.com>
To: Michael Ambrus <ambrmi09@gmail.com>
Cc: sid@sourceware.org
Subject: Re: Building SID
Date: Fri, 02 Mar 2007 17:12:00 -0000 [thread overview]
Message-ID: <45E85AD6.1070209@redhat.com> (raw)
In-Reply-To: <45E8499F.7020702@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 805 bytes --]
Dave Brolley wrote:
> Michael Ambrus wrote:
>
>
>>
>> Compiling the files arm.cxx and compTIMERS.cxx both give the same error:
>>
>> /home/ambrmi09/projects/sid/src/sid/component/timers/arm7t/arm7t-timer.h:142:
>>
>> error: looser throw specifier for 'virtual
>> armTimerNoSched::~armTimerNoSched()'
>> /home/ambrmi09/projects/sid/src/sid/component/timers/arm7t/arm7t-timer.h:70:
>>
>> error: overriding 'virtual armTimer::~armTimer() throw ()'
>
> This relates to the removal of throw () specifiers from the SID API
> recently. The correct patch is to remove the throw specifier on
> ~armTimer completely. I'll test it and commit it, hopefully today.
I reviewed this again and have committed the attached patch which adds
the correct throw specifier to the destructor of armTimerNoSched.
Dave
>
[-- Attachment #2: sid.throw.ChangeLog --]
[-- Type: text/plain, Size: 138 bytes --]
2007-03-02 Dave Brolley <brolley@redhat.com>
* arm7t-timer.h (~armTimerNoSched): New virtual destructor with empty
throw specifier.
[-- Attachment #3: sid.throw.patch.txt --]
[-- Type: text/plain, Size: 603 bytes --]
Index: sid/component/timers/arm7t/arm7t-timer.h
===================================================================
RCS file: /cvs/src/src/sid/component/timers/arm7t/arm7t-timer.h,v
retrieving revision 1.3
diff -c -p -r1.3 arm7t-timer.h
*** sid/component/timers/arm7t/arm7t-timer.h 12 Feb 2005 16:25:47 -0000 1.3
--- sid/component/timers/arm7t/arm7t-timer.h 2 Mar 2007 17:01:37 -0000
*************** class armTimerNoSched: public armTimer
*** 142,147 ****
--- 142,148 ----
{
public:
armTimerNoSched();
+ ~armTimerNoSched() throw () {}
private:
callback_pin<armTimerNoSched> clockpin;
next prev parent reply other threads:[~2007-03-02 17:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-25 19:37 Michael Ambrus
2007-02-26 0:21 ` Frank Ch. Eigler
2007-02-26 0:45 ` Michael Ambrus
2007-02-26 18:54 ` Frank Ch. Eigler
2007-02-26 19:42 ` Michael Ambrus
2007-03-02 14:18 ` Michael Ambrus
2007-03-02 15:58 ` Dave Brolley
2007-03-02 16:31 ` Michael Ambrus
2007-03-02 17:22 ` Frank Ch. Eigler
2007-03-02 18:00 ` Michael Ambrus
2007-03-02 18:11 ` Frank Ch. Eigler
2007-03-02 18:22 ` Michael Ambrus
2007-03-02 18:45 ` Dave Brolley
2007-03-02 20:03 ` Michael Ambrus
[not found] ` <20070303011808.GC18185@redhat.com>
[not found] ` <81c474d20703030457j3775edd7x78211179d3f6d62e@mail.gmail.com>
[not found] ` <20070303143422.GD18185@redhat.com>
[not found] ` <81c474d20703030639i40a30aa4v6a01be2e4160e4cd@mail.gmail.com>
[not found] ` <20070303144102.GF18185@redhat.com>
[not found] ` <81c474d20703030700k2b8d4b32h9e323f0bb8ce90a7@mail.gmail.com>
[not found] ` <20070303163018.GG18185@redhat.com>
[not found] ` <81c474d20703050549n3577b589gdeccea3db5f33ae7@mail.gmail.com>
[not found] ` <20070305173328.GA8990@redhat.com>
2007-03-05 22:09 ` Michael Ambrus
2007-03-05 22:50 ` Frank Ch. Eigler
2007-03-02 17:12 ` Dave Brolley [this message]
2007-02-26 16:26 ` Dave Brolley
2007-02-26 17:51 ` Michael Ambrus
2007-02-26 18:54 ` Dave Brolley
2007-02-26 19:12 ` Michael Ambrus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E85AD6.1070209@redhat.com \
--to=brolley@redhat.com \
--cc=ambrmi09@gmail.com \
--cc=sid@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).