From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24652 invoked by alias); 2 Mar 2007 17:12:10 -0000 Received: (qmail 24642 invoked by uid 22791); 2 Mar 2007 17:12:09 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 02 Mar 2007 17:12:01 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l22HBtN8027867; Fri, 2 Mar 2007 12:11:57 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l22HBssb017544; Fri, 2 Mar 2007 12:11:54 -0500 Received: from [127.0.0.1] (vpn-14-55.rdu.redhat.com [10.11.14.55]) by potter.sfbay.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l22HBo9f019615; Fri, 2 Mar 2007 12:11:53 -0500 Message-ID: <45E85AD6.1070209@redhat.com> Date: Fri, 02 Mar 2007 17:12:00 -0000 From: Dave Brolley User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) MIME-Version: 1.0 To: Michael Ambrus CC: sid@sourceware.org Subject: Re: Building SID References: <81c474d20702251137j3e65f89aidf58a2e4cf019252@mail.gmail.com> <20070226002136.GA19131@redhat.com> <81c474d20702251644n352ea169kdf6f9ffcbc591fb7@mail.gmail.com> <20070226185359.GC19131@redhat.com> <81c474d20703020618l3806c167ib8d04a6fa94399d@mail.gmail.com> <45E8499F.7020702@redhat.com> In-Reply-To: <45E8499F.7020702@redhat.com> Content-Type: multipart/mixed; boundary="------------070305070200050105060805" X-IsSubscribed: yes Mailing-List: contact sid-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: sid-owner@sourceware.org X-SW-Source: 2007-q1/txt/msg00037.txt.bz2 This is a multi-part message in MIME format. --------------070305070200050105060805 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 805 Dave Brolley wrote: > Michael Ambrus wrote: > > >> >> Compiling the files arm.cxx and compTIMERS.cxx both give the same error: >> >> /home/ambrmi09/projects/sid/src/sid/component/timers/arm7t/arm7t-timer.h:142: >> >> error: looser throw specifier for 'virtual >> armTimerNoSched::~armTimerNoSched()' >> /home/ambrmi09/projects/sid/src/sid/component/timers/arm7t/arm7t-timer.h:70: >> >> error: overriding 'virtual armTimer::~armTimer() throw ()' > > This relates to the removal of throw () specifiers from the SID API > recently. The correct patch is to remove the throw specifier on > ~armTimer completely. I'll test it and commit it, hopefully today. I reviewed this again and have committed the attached patch which adds the correct throw specifier to the destructor of armTimerNoSched. Dave > --------------070305070200050105060805 Content-Type: text/plain; name="sid.throw.ChangeLog" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="sid.throw.ChangeLog" Content-length: 138 2007-03-02 Dave Brolley * arm7t-timer.h (~armTimerNoSched): New virtual destructor with empty throw specifier. --------------070305070200050105060805 Content-Type: text/plain; name="sid.throw.patch.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="sid.throw.patch.txt" Content-length: 603 Index: sid/component/timers/arm7t/arm7t-timer.h =================================================================== RCS file: /cvs/src/src/sid/component/timers/arm7t/arm7t-timer.h,v retrieving revision 1.3 diff -c -p -r1.3 arm7t-timer.h *** sid/component/timers/arm7t/arm7t-timer.h 12 Feb 2005 16:25:47 -0000 1.3 --- sid/component/timers/arm7t/arm7t-timer.h 2 Mar 2007 17:01:37 -0000 *************** class armTimerNoSched: public armTimer *** 142,147 **** --- 142,148 ---- { public: armTimerNoSched(); + ~armTimerNoSched() throw () {} private: callback_pin clockpin; --------------070305070200050105060805--