From: Dave Brolley <brolley@redhat.com>
To: Nick Clifton <nickc@redhat.com>
Cc: "Frank Ch. Eigler" <fche@redhat.com>,
cgen@sourceware.org, sid@sourceware.org, dj@redhat.com
Subject: Re: RFA: XStormy16: Fix implementation of MOVF instruction
Date: Tue, 02 Nov 2010 16:30:00 -0000 [thread overview]
Message-ID: <4CD03CAA.70805@redhat.com> (raw)
In-Reply-To: <4CD039BE.2080604@redhat.com>
OK with me.
Thanks,
Dave
On 11/02/2010 12:18 PM, Nick Clifton wrote:
> Hi Dave, Hi Frank,
>
>> I don't know that this port has a maintainer for CGEN/SID. However, I
>> think that testing against a specific test case which exhibits the bug
>> and running the SID testsuite for --target=xstormy16-elf should be
>> sufficient. I see that there is no test case for this insn in
>> sid/component/testsuite/sidcomp.cgen-cpu.xstormy16, so please add one
>> before running the test suite.
>
> The attached patch does that. (It actually adds 4 new tests, one for
> each variant of the pre-decrement/post-increment load/store version of
> the MOVF instruction).
>
> In the course of checking the patch I also found that all of the
> XStormy16 tests were failing because the "pass" and "fail" macros had
> not been updated to match the new parameter layout for the write
> syscall. So the patch fixes this as well.
>
> Then I found several testcases that were failing due to endian
> mistakes, so those have been fixed as well.
>
> Tested with an xstormy16-elf toolchain and no regressions.
>
> OK to apply (along with the original MOVF patch) ?
>
> Cheers
> Nick
> 2010-11-02 Nick Clifton <nickc@redhat.com>
>
> * testutils.inc (pass): Update parameter layout for write syscall.
> (fail): Likewise.
> * movgrgrii.cgs: Fix endianness typo in assertion.
> * movgrgriipostinc.cgs: Likewise.
> * movgrgriipredec.cgs: Likewise.
> * movgrgripostinc.cgs: Likewise.
> * movgrgripredec.cgs: Likewise.
> * movgrigr.cgs: Likewise.
> * movgriipostincgr.cgs: Likewise.
> * movgripostincgr.cgs: Likewise.
> * movgripredecgr.cgs: Likewise.
> * rrcgrgr.cgs: Rotate only inserts carry flag once.
> * rrcgrimm4.cgs: Likewise.
> * movfgrgriipostinc.cgs: New test. Checks MOVF load with
> post increment.
> * movfgrgriipredec.cgs: New test. Checks MOVF load with
> pre decrement.
> * movfgriipostincgr.cgs: New test. Checks MOVF store with
> post increment.
> * movfgriipostincgr.cgs: New test. Checks MOVF store with
> pre decrement.
prev parent reply other threads:[~2010-11-02 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 9:59 Nick Clifton
2010-11-01 15:48 ` Dave Brolley
2010-11-02 16:18 ` Nick Clifton
2010-11-02 16:30 ` Dave Brolley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD03CAA.70805@redhat.com \
--to=brolley@redhat.com \
--cc=cgen@sourceware.org \
--cc=dj@redhat.com \
--cc=fche@redhat.com \
--cc=nickc@redhat.com \
--cc=sid@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).