From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10966 invoked by alias); 2 Nov 2010 16:30:44 -0000 Received: (qmail 10953 invoked by uid 22791); 2 Nov 2010 16:30:42 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Nov 2010 16:30:37 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oA2GUZbj029931 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 2 Nov 2010 12:30:35 -0400 Received: from [10.15.16.110] (dhcp-10-15-16-110.yyz.redhat.com [10.15.16.110]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oA2GUYJI000847; Tue, 2 Nov 2010 12:30:34 -0400 Message-ID: <4CD03CAA.70805@redhat.com> Date: Tue, 02 Nov 2010 16:30:00 -0000 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc13 Lightning/1.0b3pre Thunderbird/3.1.4 MIME-Version: 1.0 To: Nick Clifton CC: "Frank Ch. Eigler" , cgen@sourceware.org, sid@sourceware.org, dj@redhat.com Subject: Re: RFA: XStormy16: Fix implementation of MOVF instruction References: <4CCEE146.4050908@redhat.com> <4CD039BE.2080604@redhat.com> In-Reply-To: <4CD039BE.2080604@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact sid-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: sid-owner@sourceware.org X-SW-Source: 2010-q4/txt/msg00005.txt.bz2 OK with me. Thanks, Dave On 11/02/2010 12:18 PM, Nick Clifton wrote: > Hi Dave, Hi Frank, > >> I don't know that this port has a maintainer for CGEN/SID. However, I >> think that testing against a specific test case which exhibits the bug >> and running the SID testsuite for --target=xstormy16-elf should be >> sufficient. I see that there is no test case for this insn in >> sid/component/testsuite/sidcomp.cgen-cpu.xstormy16, so please add one >> before running the test suite. > > The attached patch does that. (It actually adds 4 new tests, one for > each variant of the pre-decrement/post-increment load/store version of > the MOVF instruction). > > In the course of checking the patch I also found that all of the > XStormy16 tests were failing because the "pass" and "fail" macros had > not been updated to match the new parameter layout for the write > syscall. So the patch fixes this as well. > > Then I found several testcases that were failing due to endian > mistakes, so those have been fixed as well. > > Tested with an xstormy16-elf toolchain and no regressions. > > OK to apply (along with the original MOVF patch) ? > > Cheers > Nick > 2010-11-02 Nick Clifton > > * testutils.inc (pass): Update parameter layout for write syscall. > (fail): Likewise. > * movgrgrii.cgs: Fix endianness typo in assertion. > * movgrgriipostinc.cgs: Likewise. > * movgrgriipredec.cgs: Likewise. > * movgrgripostinc.cgs: Likewise. > * movgrgripredec.cgs: Likewise. > * movgrigr.cgs: Likewise. > * movgriipostincgr.cgs: Likewise. > * movgripostincgr.cgs: Likewise. > * movgripredecgr.cgs: Likewise. > * rrcgrgr.cgs: Rotate only inserts carry flag once. > * rrcgrimm4.cgs: Likewise. > * movfgrgriipostinc.cgs: New test. Checks MOVF load with > post increment. > * movfgrgriipredec.cgs: New test. Checks MOVF load with > pre decrement. > * movfgriipostincgr.cgs: New test. Checks MOVF store with > post increment. > * movfgriipostincgr.cgs: New test. Checks MOVF store with > pre decrement.