From mboxrd@z Thu Jan  1 00:00:00 1970
From: Greg McGary <greg@mcgary.org>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: cgen@sources.redhat.com, sid@sources.redhat.com
Subject: Re: branch probability hinting
Date: Wed, 28 Feb 2001 15:01:00 -0000
Message-id: <mswvaajtuo.fsf@mcgary.org>
References: <20010228173521.A14580@redhat.com>
X-SW-Source: 2001-q1/msg00073.html

"Frank Ch. Eigler" <fche@redhat.com> writes:

> One is used thusly (and the other, vice versa):
> [ ... ]
> 		if UNLIKELY(error) {

Cool.  Only one nit to pick:

Please don't encourage people to write code that appears to be
syntactically invalid.  I know that the parens are part of the
expansion of LIKELY & UNLIKELY, but lexical tools such as indent get
confused.  I'd rather see uses like this:

		if (UNLIKELY(error)) {

Greg