public inbox for sid@sourceware.org
 help / color / mirror / Atom feed
From: fche@redhat.com (Frank Ch. Eigler)
To: nsd@redhat.com (Nick Duffek)
Cc: cagney@redhat.com, jtc@redback.com, sid@sources.redhat.com,
	gdb-patches@cygnus.com
Subject: Re: Possible remote.c patch for Z-packet breakpoints + Harvard + SID
Date: Mon, 16 Jul 2001 15:05:00 -0000	[thread overview]
Message-ID: <o5g0bw7cnc.fsf@toenail.toronto.redhat.com> (raw)
In-Reply-To: <200107161931.f6GJVV719853.cygnus.project.sid@rtl.cygnus.com>

nsd wrote:

: [...]
: I see your point, though I think it's debatable.  For one thing, Z-packet
: breakpoints are tagged as "Z_PACKET_SOFTWARE_BP" in gdb/remote.c, so it
: looks like they're intended to be a generic protocol speedup rather than a
: hardware breakpoint mechanism.
: [...]

That's true - it makes me rethink my earlier point.

: I proposed a patch in January to call BREAKPOINT_FROM_PC() before rather
: than after remote.c stores hardware breakpoint addresses in outgoing
: packets, but it was decided that such a change should be at a higher
: level, e.g. in target_insert_breakpoint().
: 
: This problem can't be fixed in target_insert_breakpoint(), because the
: distinction between "hardware" (Z-packet) and software breakpoints is made
: in remote.c.
: [...]

If this gdb-side approach is not deemed acceptable to gdb folks, we
may be able to make complementary changes on the sid side without too
much littering.  

One possibility: map hardware breakpoints to mask/value-type sid
"triggerpoints" on the PC register instead of plain value-type ones;
parametrize the gdb-interface-component with the desired mask for a
target.  This sort of thing may be useful for PC-range breakpoints
too.


- FChE

      parent reply	other threads:[~2001-07-16 15:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <o5pub0sqqy.fsf@toenail.toronto.redhat.com>
2001-07-16 14:35 ` Nick Duffek
2001-07-16 16:42   ` Mark Salter
     [not found] ` <200107161931.f6GJVV719853.cygnus.project.sid@rtl.cygnus.com>
2001-07-16 15:05   ` Frank Ch. Eigler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=o5g0bw7cnc.fsf@toenail.toronto.redhat.com \
    --to=fche@redhat.com \
    --cc=cagney@redhat.com \
    --cc=gdb-patches@cygnus.com \
    --cc=jtc@redback.com \
    --cc=nsd@redhat.com \
    --cc=sid@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).