From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sid-return-774-listarch-sid=sources.redhat.com@sources.redhat.com>
Received: (qmail 14794 invoked by alias); 26 Mar 2004 20:24:25 -0000
Mailing-List: contact sid-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:sid-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/sid/>
List-Post: <mailto:sid@sources.redhat.com>
List-Help: <mailto:sid-help@sources.redhat.com>, <http://sources.redhat.com/lists.html#faqs>
Sender: sid-owner@sources.redhat.com
Received: (qmail 14779 invoked from network); 26 Mar 2004 20:24:20 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 26 Mar 2004 20:24:20 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i2QKOK1X026955
	for <sid@sources.redhat.com>; Fri, 26 Mar 2004 15:24:20 -0500
Received: from zenia.home.redhat.com (porkchop.devel.redhat.com [172.16.58.2])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i2QKOIj30466;
	Fri, 26 Mar 2004 15:24:19 -0500
To: sid@sources.redhat.com
Subject: Re: PATCH: fix up fake BFD functions in cgen-cpu/tracedis.cxx
References: <vt21xnjyx94.fsf@zenia.home>
From: Jim Blandy <jimb@redhat.com>
Date: Fri, 26 Mar 2004 20:24:00 -0000
In-Reply-To: <vt21xnjyx94.fsf@zenia.home>
Message-ID: <vt2y8pnpdb2.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-q1/txt/msg00051.txt.bz2


I've committed this.

Jim Blandy <jimb@redhat.com> writes:

> In trying to build SID with --disable-shared, I found that linking
> 'sid' died because the references to these functions in libopcodes
> weren't being satisfied.  As it turns out:
> 
> $ nm tracedis.o | grep bfd_get_bits
> 000024de T _Z12bfd_get_bitsPhii
> $
> 
> But when I added the 'extern "C"' thingies, the compiler was suddenly
> able to check the definitions against the declarations in bfd/bfd.h
> again.  Those changed recently; see Alan Modra's 2004-03-15 change in
> bfd/ChangeLog.
> 
> 2004-03-23  Jim Blandy  <jimb@redhat.com>
> 
> 	* tracedis.cxx (bfd_get_arch, bfd_getb16, bfd_getl16, bfd_getb32)
> 	(bfd_getl32, bfd_put_bits, bfd_get_bits, bfd_lookup_arch): These
> 	definitions are meant to satisfy references in libopcodes, which
> 	is C code, so declare these with 'extern "C"'.  Adjust types to
> 	match those declared in the BFD header file.