From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20229 invoked by alias); 12 Jul 2006 23:20:13 -0000 Received: (qmail 20214 invoked by uid 22791); 12 Jul 2006 23:20:12 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 12 Jul 2006 23:20:10 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k6CNK8Ht020277; Wed, 12 Jul 2006 19:20:08 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k6CNK7IJ011797; Wed, 12 Jul 2006 19:20:07 -0400 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id k6CNK7ve019402; Wed, 12 Jul 2006 19:20:07 -0400 Received: from ton.toronto.redhat.com (ton.toronto.redhat.com [172.16.14.15]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 49B8D8002A2; Wed, 12 Jul 2006 19:20:07 -0400 (EDT) Received: from ton.toronto.redhat.com (localhost.localdomain [127.0.0.1]) by ton.toronto.redhat.com (8.13.1/8.13.1) with ESMTP id k6CNK7n6031393; Wed, 12 Jul 2006 19:20:07 -0400 Received: (from fche@localhost) by ton.toronto.redhat.com (8.13.1/8.13.1/Submit) id k6CNK7LX031390; Wed, 12 Jul 2006 19:20:07 -0400 To: Dave Brolley Cc: cgen@sources.redhat.com, sid@sources.redhat.com Subject: Re: [patch][rfa] Don't Generate Code to Support Unused Write Stacks References: <44B564FE.1030002@redhat.com> From: fche@redhat.com (Frank Ch. Eigler) Date: Wed, 12 Jul 2006 23:20:00 -0000 In-Reply-To: <44B564FE.1030002@redhat.com> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact sid-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: sid-owner@sourceware.org X-SW-Source: 2006-q3/txt/msg00008.txt.bz2 brolley wrote: > [...] > When generating write stacks and the supporting code in order to > suppor the (delay ...) rtl construct for SID, cgen currently generates > a write stack for all registers and memory modes regardless of whether > they are used or not. [...] > For the internal port for which performance was an issue, this yielded > an improvement of 17%. [...] Sounds good. I'm surprised though that your change should cause such a noticeable improvement. It may be that the sid-side code to handle the write queue testing/iteration is rather deficient. (Try adding some UNLIKELY markers to the CPU::writeback() function's while() conditions.) - FChE