Re: Patches...[was: Re: SourceNav release ... ]

Re: Patches...[was: Re: SourceNav release ... ]

[Ian Roxborough]

Hi,

This is the version of frink that I hacked to work with
Itcl3.0 code:

http://people.redhat.com/irox/frink/frink-1.2p40-itcl3.tar.gz

I did this work against frink version 1.2 and then version
2.0 came out and I didn't have enough time to move my changes
into the 2.0 version and submit them back.

There is still no requirement to run frink on your code
before submitting a patch.  Frink was mainly used for us
to unify the coding style (as SN has had many different
developers using different coding styles in the past).

Ian.

On Wed, 9 Jan 2002 10:14:31 +0100  Bernard Dautrevaux <Dautrevaux@microprocess.com> wrote:
>
> > -----Original Message-----
> > From: Ian Roxborough [mailto:irox@redhat.com]
> > Sent: Tuesday, January 08, 2002 9:27 PM
> > To: Dautrevaux@microprocess.com
> > Cc: sourcenav@redhat.com
> > Subject: Re: Patches...[was: Re: SourceNav release ... ]
> > 
> > 
> > 
> > Hi Bernard,
> > 
> > thanks for pointing that out, I've removed the requirement
> > to run frink for the time being and updated the webpage
> > to reflect this.
> > 
> >   Ian.
> > 
> 
> Frink looking like a nice tool for this purpose, couldn't the itcl-aware
> version be either contributed to the original frink (if the fact that I
> can't even doanload it through your link is just a temporary situation), or
> proposed as an html download or at least though CVS?
> 
> TIA
> 
> 	Bernard
> 
> --------------------------------------------
> Bernard Dautrevaux
> Microprocess Ingenierie
> 97 bis, rue de Colombes
> 92400 COURBEVOIE
> FRANCE
> Tel:	+33 (0) 1 47 68 80 80
> Fax:	+33 (0) 1 47 88 97 85
> e-mail:	dautrevaux@microprocess.com
> 		b.dautrevaux@usa.net
> -------------------------------------------- 

RE: Patches...[was: Re: SourceNav release ... ]

[Bernard Dautrevaux]

> -----Original Message-----
> From: Ian Roxborough [mailto:irox@redhat.com]
> Sent: Monday, January 07, 2002 10:27 PM
> To: Ian Roxborough
> Cc: sourcenav@sources.redhat.com
> Subject: Patches...[was: Re: SourceNav release ... ]
> 
> 
> On Mon, 7 Jan 2002 13:14:12 -0800 Ian Roxborough 
> <irox@redhat.com> wrote:
> >
> > Before that I need to write a "how to submit patches" web
> > page so I can reject patches and point people to this page
> > so they can get there patch into shape.  Just simple things
> > like having a changelog entry, matching coding style and stuff.
> 
> It's here and always was:
> http://sources.redhat.com/sourcenav/contrib.html
> 
> It was already there (scroll down to "Submitting Patches").

Fine page; only problem: it says we must format tcl/tk code with frink, as
you've modified it to accept [incr tcl]. It seems perfectly reasonable...
except almost nobody can download this version of frink, as the ftp server
on source.redhat.com is restricted (AFAICR only mirrors are able to get to
source.redhat.com in FTP due to load problems). 

So where could we get this "frink" tcl/tk formatter that seems mandatory to
provide patches to the current snapshots/CVS version of SN?

Regards,

	Bernard

--------------------------------------------
Bernard Dautrevaux
Microprocess Ingenierie
97 bis, rue de Colombes
92400 COURBEVOIE
FRANCE
Tel:	+33 (0) 1 47 68 80 80
Fax:	+33 (0) 1 47 88 97 85
e-mail:	dautrevaux@microprocess.com
		b.dautrevaux@usa.net
-------------------------------------------- 

Patches...[was: Re: SourceNav release ... ]

[Ian Roxborough]

On Mon, 7 Jan 2002 13:14:12 -0800 Ian Roxborough <irox@redhat.com> wrote:
>
> Before that I need to write a "how to submit patches" web
> page so I can reject patches and point people to this page
> so they can get there patch into shape.  Just simple things
> like having a changelog entry, matching coding style and stuff.

It's here and always was:
http://sources.redhat.com/sourcenav/contrib.html

It was already there (scroll down to "Submitting Patches").

A number of people have submitted small patches without
ChangeLog entries.  Please resubmit your patch complete
with a plain text ChangeLog entry (i.e. not part of the diff)
if you wish to have your patch include in the CVS repository.

Thanks,

  Ian.