From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourcenav-return-1731-listarch-sourcenav=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 29270 invoked by alias); 4 Feb 2002 21:25:56 -0000
Mailing-List: contact sourcenav-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:sourcenav-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/sourcenav/>
List-Post: <mailto:sourcenav@sources.redhat.com>
List-Help: <mailto:sourcenav-help@sources.redhat.com>, <http://sources.redhat.com/lists.html#faqs>
Sender: sourcenav-owner@sources.redhat.com
Received: (qmail 29196 invoked from network); 4 Feb 2002 21:25:53 -0000
Received: from unknown (HELO shell4.bayarea.net) (209.128.82.1)
  by sources.redhat.com with SMTP; 4 Feb 2002 21:25:53 -0000
Received: from modrick (209-128-79-218.BAYAREA.NET [209.128.79.218])
	by shell4.bayarea.net (8.9.3/8.9.3) with SMTP id NAA20140
	for <sourcenav@sources.redhat.com>; Mon, 4 Feb 2002 13:25:52 -0800
	(envelope-from supermo@bayarea.net)
Date: Mon, 04 Feb 2002 13:32:00 -0000
From: Mo DeJong <supermo@bayarea.net>
To: sourcenav <sourcenav@sources.redhat.com>
Subject: [Patch] Fix -readonly option in combo.tcl
Message-Id: <20020204132417.63049782.supermo@bayarea.net>
Organization: House of Mirth
X-Mailer: Sylpheed version 0.4.99cvs6 (GTK+ 1.2.7; i686-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-q1/txt/msg00055.txt.bz2

Here is a small patch that fixes the combo class so that it works
with a stock Tk 8.3. The previous version depended on some local changes
that are not available in the stock Tk 8.3 and are not in the Tk
version on sources.

Since this is a small change I assume it will be covered by the
"Small changes can be accepted without a copyright
assignment form on file" text from the contrib webpage.

Mo

2002-02-04  Mo DeJong  <supermo@bayarea.net>

	* gui/combo.tcl (-state, -readonly): Implement a read
	only entry widget with a binding that ignores all
	key press events. The previous implementation depended
	on a local modification that added a -state readonly
	property to the entry widget. We can't depend on that
	modification since it will not exist in a system
	install of Tk 8.3.
	* tests/gui/combo.test: Add test case for selecttext
	member function.

--- gui/combo.tcl	Mon Feb 26 09:15:15 2001
+++ gui/combo.tcl	Mon Feb  4 00:20:51 2002
@@ -391,8 +391,9 @@
     # as a keep option to the widgets since
     # we need to configure the entry and
     # keep track of the -readonly option.
-    # We also only want to support to
-    # -state options, normal and disabled.
+    # The -state readonly is also not available
+    # in Tk 8.3, it only supports normal
+    # and disabled.
 
     itk_option define -state state State normal {
         if {$itk_option(-state) != "normal" &&
@@ -406,22 +407,23 @@
         if {$itk_option(-state) == "disabled"} {
             $itk_component(entry) configure -state disabled
         } else {
+            $itk_component(entry) configure -state normal
+
             if {$itk_option(-readonly)} {
-                $itk_component(entry) configure -state readonly
+                bind $itk_component(entry) <KeyPress> break
             } else {
-                $itk_component(entry) configure -state normal
+                bind $itk_component(entry) <KeyPress> {}
             }
         }
     }
 
     itk_option define -readonly readOnly ReadOnly 0 {
         if {$itk_option(-readonly)} {
-            if {$itk_option(-state) == "normal"} {
-                $itk_component(entry) configure -state readonly
+            if {[string equal $itk_option(-state) "normal"]} {
+                bind $itk_component(entry) <KeyPress> break
             }
         } else {
-            $itk_component(entry) configure -state \
-                $itk_option(-state)
+            bind $itk_component(entry) <KeyPress> {}
         }
     }