* Patch for fix libgui compile under VC++
@ 2002-02-22 3:50 Mo DeJong
2002-02-22 15:53 ` Mo DeJong
0 siblings, 1 reply; 5+ messages in thread
From: Mo DeJong @ 2002-02-22 3:50 UTC (permalink / raw)
To: sourcenav; +Cc: insight
Hi all.
I noticed that the recent import of tkTable 2.7 has broken the
libgui build under VC++. The patch to fix the problem is
attached. This change should have no effect under Unix
systems.
2002-02-22 Mo DeJong <supermo@bayarea.net>
* src/Makefile.am: Add -DBUILD_tkTable define so
that newly imported tkTable sources compile
with VC++.
* src/Makefile.in: Regen.
--- /tmp/Makefile.am Fri Feb 22 02:32:52 2002
+++ src/Makefile.am Fri Feb 22 02:23:27 2002
@@ -49,3 +49,4 @@
-DTBL_COMMAND=\"$(TBL_COMMAND)\"\
--DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"
+-DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"\
+-DBUILD_tkTable
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch for fix libgui compile under VC++
2002-02-22 3:50 Patch for fix libgui compile under VC++ Mo DeJong
@ 2002-02-22 15:53 ` Mo DeJong
2002-02-23 17:41 ` Keith Seitz
0 siblings, 1 reply; 5+ messages in thread
From: Mo DeJong @ 2002-02-22 15:53 UTC (permalink / raw)
To: insight; +Cc: sourcenav
On Fri, 22 Feb 2002 02:42:22 -0800
Mo DeJong <supermo@bayarea.net> wrote:
> I noticed that the recent import of tkTable 2.7 has broken the
> libgui build under VC++.
A short chat with Keith has convinced me to revise my suggested
patch to instead define -DSTATIC_BUILD when building libgui.
This patch also includes the patch change for src/Makefile.in.
cheers
Mo
2002-02-22 Mo DeJong <supermo@bayarea.net>
* src/Makefile.am: Add -DSTATIC_BUILD so
that no __declspec() is used in function
delarations. This fixes the build under VC++.
* src/Makefile.in: Regen.
Index: src/Makefile.am
===================================================================
RCS file: /cvs/src/src/libgui/src/Makefile.am,v
retrieving revision 1.5
diff -u -r1.5 Makefile.am
--- Makefile.am 2002/02/05 23:16:15 1.5
+++ Makefile.am 2002/02/22 22:44:07
@@ -47,7 +47,8 @@
$(TKHDIR)/../unix $(TKHDIR)/../win \
-DTBL_VERSION=\"$(TBL_VERSION)\"\
-DTBL_COMMAND=\"$(TBL_COMMAND)\"\
--DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"
+-DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"\
+-DSTATIC_BUILD
TKTABLE_SOURCES = tkTable.c tkTableCell.c tkTableCellSort.c \
tkTableCmds.c tkTableEdit.c tkTableTag.c tkTableWin.c tkTableUtil.c
Index: src/Makefile.in
===================================================================
RCS file: /cvs/src/src/libgui/src/Makefile.in,v
retrieving revision 1.10
diff -u -r1.10 Makefile.in
--- Makefile.in 2002/02/05 23:16:16 1.10
+++ Makefile.in 2002/02/22 22:44:08
@@ -172,7 +173,8 @@
$(TKHDIR)/../unix $(TKHDIR)/../win \
-DTBL_VERSION=\"$(TBL_VERSION)\"\
-DTBL_COMMAND=\"$(TBL_COMMAND)\"\
--DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"
+-DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"\
+-DSTATIC_BUILD
TKTABLE_SOURCES = tkTable.c tkTableCell.c tkTableCellSort.c \
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Patch for fix libgui compile under VC++
2002-02-22 15:53 ` Mo DeJong
@ 2002-02-23 17:41 ` Keith Seitz
2002-02-23 17:44 ` Mo DeJong
0 siblings, 1 reply; 5+ messages in thread
From: Keith Seitz @ 2002-02-23 17:41 UTC (permalink / raw)
To: Mo DeJong; +Cc: insight, sourcenav
On Fri, 22 Feb 2002, Mo DeJong wrote:
> On Fri, 22 Feb 2002 02:42:22 -0800
> Mo DeJong <supermo@bayarea.net> wrote:
>
> > I noticed that the recent import of tkTable 2.7 has broken the
> > libgui build under VC++.
>
> A short chat with Keith has convinced me to revise my suggested
> patch to instead define -DSTATIC_BUILD when building libgui.
> This patch also includes the patch change for src/Makefile.in.
Yes, definitely.
Thank you for your patch. You do have an assignment, right? ;-)
Keith
> 2002-02-22 Mo DeJong <supermo@bayarea.net>
>
> * src/Makefile.am: Add -DSTATIC_BUILD so
> that no __declspec() is used in function
> delarations. This fixes the build under VC++.
> * src/Makefile.in: Regen.
>
> Index: src/Makefile.am
> ===================================================================
> RCS file: /cvs/src/src/libgui/src/Makefile.am,v
> retrieving revision 1.5
> diff -u -r1.5 Makefile.am
> --- Makefile.am 2002/02/05 23:16:15 1.5
> +++ Makefile.am 2002/02/22 22:44:07
> @@ -47,7 +47,8 @@
> $(TKHDIR)/../unix $(TKHDIR)/../win \
> -DTBL_VERSION=\"$(TBL_VERSION)\"\
> -DTBL_COMMAND=\"$(TBL_COMMAND)\"\
> --DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"
> +-DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"\
> +-DSTATIC_BUILD
>
> TKTABLE_SOURCES = tkTable.c tkTableCell.c tkTableCellSort.c \
> tkTableCmds.c tkTableEdit.c tkTableTag.c tkTableWin.c tkTableUtil.c
> Index: src/Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/libgui/src/Makefile.in,v
> retrieving revision 1.10
> diff -u -r1.10 Makefile.in
> --- Makefile.in 2002/02/05 23:16:16 1.10
> +++ Makefile.in 2002/02/22 22:44:08
> @@ -172,7 +173,8 @@
> $(TKHDIR)/../unix $(TKHDIR)/../win \
> -DTBL_VERSION=\"$(TBL_VERSION)\"\
> -DTBL_COMMAND=\"$(TBL_COMMAND)\"\
> --DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"
> +-DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"\
> +-DSTATIC_BUILD
>
>
> TKTABLE_SOURCES = tkTable.c tkTableCell.c tkTableCellSort.c \
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2002-02-24 1:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-02-22 3:50 Patch for fix libgui compile under VC++ Mo DeJong
2002-02-22 15:53 ` Mo DeJong
2002-02-23 17:41 ` Keith Seitz
2002-02-23 17:44 ` Mo DeJong
2002-02-24 14:23 ` Keith Seitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).