public inbox for sourcenav@sourceware.org
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: Mo DeJong <supermo@bayarea.net>
Cc: <insight@sources.redhat.com>, <sourcenav@sources.redhat.com>
Subject: Re: Patch for fix libgui compile under VC++
Date: Sat, 23 Feb 2002 17:41:00 -0000	[thread overview]
Message-ID: <Pine.GSO.4.33.0202231726170.16592-100000@makita.cygnus.com> (raw)
In-Reply-To: <20020222144719.0d23dab1.supermo@bayarea.net>

On Fri, 22 Feb 2002, Mo DeJong wrote:

> On Fri, 22 Feb 2002 02:42:22 -0800
> Mo DeJong <supermo@bayarea.net> wrote:
>
> > I noticed that the recent import of tkTable 2.7 has broken the
> > libgui build under VC++.
>
> A short chat with Keith has convinced me to revise my suggested
> patch to instead define -DSTATIC_BUILD when building libgui.
> This patch also includes the patch change for src/Makefile.in.

Yes, definitely.

Thank you for your patch. You do have an assignment, right? ;-)
Keith

> 2002-02-22  Mo DeJong  <supermo@bayarea.net>
>
> 	* src/Makefile.am: Add -DSTATIC_BUILD so
> 	that no __declspec() is used in function
> 	delarations. This fixes the build under VC++.
> 	* src/Makefile.in: Regen.
>
> Index: src/Makefile.am
> ===================================================================
> RCS file: /cvs/src/src/libgui/src/Makefile.am,v
> retrieving revision 1.5
> diff -u -r1.5 Makefile.am
> --- Makefile.am	2002/02/05 23:16:15	1.5
> +++ Makefile.am	2002/02/22 22:44:07
> @@ -47,7 +47,8 @@
>  $(TKHDIR)/../unix $(TKHDIR)/../win \
>  -DTBL_VERSION=\"$(TBL_VERSION)\"\
>  -DTBL_COMMAND=\"$(TBL_COMMAND)\"\
> --DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"
> +-DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"\
> +-DSTATIC_BUILD
>
>  TKTABLE_SOURCES = tkTable.c tkTableCell.c tkTableCellSort.c \
>  tkTableCmds.c tkTableEdit.c tkTableTag.c tkTableWin.c tkTableUtil.c
> Index: src/Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/libgui/src/Makefile.in,v
> retrieving revision 1.10
> diff -u -r1.10 Makefile.in
> --- Makefile.in	2002/02/05 23:16:16	1.10
> +++ Makefile.in	2002/02/22 22:44:08
> @@ -172,7 +173,8 @@
>  $(TKHDIR)/../unix $(TKHDIR)/../win \
>  -DTBL_VERSION=\"$(TBL_VERSION)\"\
>  -DTBL_COMMAND=\"$(TBL_COMMAND)\"\
> --DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"
> +-DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"\
> +-DSTATIC_BUILD
>
>
>  TKTABLE_SOURCES = tkTable.c tkTableCell.c tkTableCellSort.c \
>

  reply	other threads:[~2002-02-24  1:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-22  3:50 Mo DeJong
2002-02-22 15:53 ` Mo DeJong
2002-02-23 17:41   ` Keith Seitz [this message]
2002-02-23 17:44     ` Mo DeJong
2002-02-24 14:23       ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.GSO.4.33.0202231726170.16592-100000@makita.cygnus.com \
    --to=keiths@redhat.com \
    --cc=insight@sources.redhat.com \
    --cc=sourcenav@sources.redhat.com \
    --cc=supermo@bayarea.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).