From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourcenav-return-1801-listarch-sourcenav=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 24971 invoked by alias); 24 Feb 2002 01:27:06 -0000
Mailing-List: contact sourcenav-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:sourcenav-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/sourcenav/>
List-Post: <mailto:sourcenav@sources.redhat.com>
List-Help: <mailto:sourcenav-help@sources.redhat.com>, <http://sources.redhat.com/lists.html#faqs>
Sender: sourcenav-owner@sources.redhat.com
Received: (qmail 24759 invoked from network); 24 Feb 2002 01:26:57 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by sources.redhat.com with SMTP; 24 Feb 2002 01:26:57 -0000
Received: from makita.cygnus.com (makita.cygnus.com [205.180.230.78])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id RAA11163;
	Sat, 23 Feb 2002 17:26:54 -0800 (PST)
Received: from localhost (keiths@localhost) by makita.cygnus.com (8.8.8+Sun/8.6.4) with ESMTP id RAA18359; Sat, 23 Feb 2002 17:26:54 -0800 (PST)
X-Authentication-Warning: makita.cygnus.com: keiths owned process doing -bs
Date: Sat, 23 Feb 2002 17:41:00 -0000
From: Keith Seitz <keiths@redhat.com>
X-X-Sender:  <keiths@makita.cygnus.com>
To: Mo DeJong <supermo@bayarea.net>
cc: <insight@sources.redhat.com>, <sourcenav@sources.redhat.com>
Subject: Re: Patch for fix libgui compile under VC++
In-Reply-To: <20020222144719.0d23dab1.supermo@bayarea.net>
Message-ID: <Pine.GSO.4.33.0202231726170.16592-100000@makita.cygnus.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-q1/txt/msg00125.txt.bz2

On Fri, 22 Feb 2002, Mo DeJong wrote:

> On Fri, 22 Feb 2002 02:42:22 -0800
> Mo DeJong <supermo@bayarea.net> wrote:
>
> > I noticed that the recent import of tkTable 2.7 has broken the
> > libgui build under VC++.
>
> A short chat with Keith has convinced me to revise my suggested
> patch to instead define -DSTATIC_BUILD when building libgui.
> This patch also includes the patch change for src/Makefile.in.

Yes, definitely.

Thank you for your patch. You do have an assignment, right? ;-)
Keith

> 2002-02-22  Mo DeJong  <supermo@bayarea.net>
>
> 	* src/Makefile.am: Add -DSTATIC_BUILD so
> 	that no __declspec() is used in function
> 	delarations. This fixes the build under VC++.
> 	* src/Makefile.in: Regen.
>
> Index: src/Makefile.am
> ===================================================================
> RCS file: /cvs/src/src/libgui/src/Makefile.am,v
> retrieving revision 1.5
> diff -u -r1.5 Makefile.am
> --- Makefile.am	2002/02/05 23:16:15	1.5
> +++ Makefile.am	2002/02/22 22:44:07
> @@ -47,7 +47,8 @@
>  $(TKHDIR)/../unix $(TKHDIR)/../win \
>  -DTBL_VERSION=\"$(TBL_VERSION)\"\
>  -DTBL_COMMAND=\"$(TBL_COMMAND)\"\
> --DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"
> +-DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"\
> +-DSTATIC_BUILD
>
>  TKTABLE_SOURCES = tkTable.c tkTableCell.c tkTableCellSort.c \
>  tkTableCmds.c tkTableEdit.c tkTableTag.c tkTableWin.c tkTableUtil.c
> Index: src/Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/libgui/src/Makefile.in,v
> retrieving revision 1.10
> diff -u -r1.10 Makefile.in
> --- Makefile.in	2002/02/05 23:16:16	1.10
> +++ Makefile.in	2002/02/22 22:44:08
> @@ -172,7 +173,8 @@
>  $(TKHDIR)/../unix $(TKHDIR)/../win \
>  -DTBL_VERSION=\"$(TBL_VERSION)\"\
>  -DTBL_COMMAND=\"$(TBL_COMMAND)\"\
> --DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"
> +-DTBL_RUNTIME=\"tkTable.tcl\" -DTBL_RUNTIME_DIR=\"$(guidir)\"\
> +-DSTATIC_BUILD
>
>
>  TKTABLE_SOURCES = tkTable.c tkTableCell.c tkTableCellSort.c \
>