public inbox for src-cvs@sourceware.org
help / color / mirror / Atom feed
From: vapier@sourceware.org
To: src-cvs@sourceware.org
Subject: src/libiberty ChangeLog md5.c
Date: Wed, 28 Nov 2012 20:00:00 -0000	[thread overview]
Message-ID: <20121128200048.21955.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/src
Module name:	src
Branch: 	gdb_7_5-branch
Changes by:	vapier@sourceware.org	2012-11-28 20:00:48

Modified files:
	libiberty      : ChangeLog md5.c 

Log message:
	libiberty/md5: fix strict alias warnings
	
	Current libiberty md5 code triggers these warnings with gcc-4.7.1 for me:
	
	libiberty/md5.c: In function 'md5_finish_ctx':
	libiberty/md5.c:117:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
	libiberty/md5.c:118:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
	
	The change below fixes things for me.  The optimized output (-O2) is the same
	before/after my change on x86_64-linux.  I imagine it'll be the same for most
	targets.  It seems simpler than using a union on the md5_ctx buffer since these
	are the only two locations in the code where this occurs.
	
	(cherry picked from current cvs HEAD)

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/libiberty/ChangeLog.diff?cvsroot=src&only_with_tag=gdb_7_5-branch&r1=1.609&r2=1.609.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/libiberty/md5.c.diff?cvsroot=src&only_with_tag=gdb_7_5-branch&r1=1.12&r2=1.12.4.1


             reply	other threads:[~2012-11-28 20:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28 20:00 vapier [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-01-31  8:10 ktietz
2012-08-01  2:46 vapier
2012-07-31  9:02 vapier
2011-09-23 20:01 dj
2011-08-12 18:44 dj
2008-03-11 16:11 dj
2002-11-16  4:39 jakub
2001-05-09 13:08 dj
2000-09-25 18:39 dj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121128200048.21955.qmail@sourceware.org \
    --to=vapier@sourceware.org \
    --cc=src-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).