From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10898 invoked by alias); 8 Nov 2013 16:39:36 -0000 Mailing-List: contact src-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: src-cvs-owner@sourceware.org Received: (qmail 10853 invoked by uid 306); 8 Nov 2013 16:39:36 -0000 Date: Fri, 08 Nov 2013 16:39:00 -0000 Message-ID: <20131108163934.10770.qmail@sourceware.org> From: tromey@sourceware.org To: src-cvs@sourceware.org Subject: gdb and binutils branch master updated. 52554a0e324951b5c58e71f2815e841377e9c50c X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 79600f4f1bd97003233076f7b07ba2ced21a0c38 X-Git-Newrev: 52554a0e324951b5c58e71f2815e841377e9c50c X-SW-Source: 2013-q4/txt/msg00078.txt.bz2 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "gdb and binutils". The branch, master has been updated via 52554a0e324951b5c58e71f2815e841377e9c50c (commit) from 79600f4f1bd97003233076f7b07ba2ced21a0c38 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=52554a0e324951b5c58e71f2815e841377e9c50c commit 52554a0e324951b5c58e71f2815e841377e9c50c Author: Tom Tromey Date: Tue Mar 19 09:23:17 2013 -0600 constify to_detach This patch constifies the target_ops method to_detach. This is a small cleanup, but also, I think, a bug-prevention fix, since gdb already acts as if the "args" argument here was const. In particular, top.c:quit_force calls kill_or_detach via iterate_over_inferiors. kill_or_detach calls target_detach, passing the same argument each time. So, if one of these methods was not const-correct, then kill_or_detach would change its behavior in a strange way. I could not build every target I modified in this patch. I've inspected them all by hand, though. Many targets do not use the "args" parameter; a couple pass it to atoi; and a few pass it on to the to_detach method of the target beneath. The only code that required a real change was in linux-nat.c, and that only needed the introduction of a temporary variable for const-correctness. 2013-11-08 Tom Tromey * aix-thread.c (aix_thread_detach): Update. * corelow.c (core_detach): Update. * darwin-nat.c (darwin_detach): Update. * dec-thread.c (dec_thread_detach): Update. * gnu-nat.c (gnu_detach): Update. * go32-nat.c (go32_detach): Update. * inf-ptrace.c (inf_ptrace_detach): Update. * inf-ttrace.c (inf_ttrace_detach): Update. * linux-fork.c (linux_fork_detach): Update. * linux-fork.h (linux_fork_detach): Update. * linux-nat.c (linux_nat_detach): Update. Introduce "tem" local for const-correctness. * linux-thread-db.c (thread_db_detach): Update. * monitor.c (monitor_detach): Update. * nto-procfs.c (procfs_detach): Update. * procfs.c (procfs_detach): Update. * record.c (record_detach): Update. * record.h (record_detach): Update. * remote-m32r-sdi.c (m32r_detach): Update. * remote-mips.c (mips_detach): Update. * remote-sim.c (gdbsim_detach): Update. * remote.c (remote_detach_1, remote_detach) (extended_remote_detach): Update. * sol-thread.c (sol_thread_detach): Update. * target.c (target_detach): Make "args" const. (init_dummy_target): Update. * target.h (struct target_ops) : Make argument const. (target_detach): Likewise. * windows-nat.c (windows_detach): Update. ----------------------------------------------------------------------- Summary of changes: gdb/ChangeLog | 32 ++++++++++++++++++++++++++++++++ gdb/aix-thread.c | 2 +- gdb/corelow.c | 4 +--- gdb/darwin-nat.c | 2 +- gdb/dec-thread.c | 2 +- gdb/gnu-nat.c | 2 +- gdb/go32-nat.c | 2 +- gdb/inf-ptrace.c | 2 +- gdb/inf-ttrace.c | 2 +- gdb/linux-fork.c | 2 +- gdb/linux-fork.h | 2 +- gdb/linux-nat.c | 9 ++++++--- gdb/linux-thread-db.c | 2 +- gdb/monitor.c | 2 +- gdb/nto-procfs.c | 2 +- gdb/procfs.c | 4 ++-- gdb/record.c | 2 +- gdb/record.h | 2 +- gdb/remote-m32r-sdi.c | 2 +- gdb/remote-mips.c | 4 +--- gdb/remote-sim.c | 2 +- gdb/remote.c | 8 +++----- gdb/sol-thread.c | 2 +- gdb/target.c | 4 ++-- gdb/target.h | 4 ++-- gdb/windows-nat.c | 2 +- 26 files changed, 67 insertions(+), 38 deletions(-) hooks/post-receive -- gdb and binutils