From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22000 invoked by alias); 9 Jun 2010 14:21:56 -0000 Received: (qmail 21969 invoked by uid 9112); 9 Jun 2010 14:21:56 -0000 Date: Wed, 09 Jun 2010 14:21:00 -0000 Message-ID: <20100609142155.21958.qmail@sourceware.org> From: mark@sourceware.org To: systemtap-cvs@sourceware.org Subject: [SCM] systemtap: system-wide probe/trace tool branch, master, updated. release-1.2-232-g473b6ce X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 6342d92ba53341b61524c001785cd116259e04dc X-Git-Newrev: 473b6ced23aea05af435ab6043b09c4250d34f5f Mailing-List: contact systemtap-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-cvs-owner@sourceware.org List-Archive: Reply-To: systemtap@sourceware.org X-SW-Source: 2010-q2/txt/msg00157.txt.bz2 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "systemtap: system-wide probe/trace tool". The branch, master has been updated via 473b6ced23aea05af435ab6043b09c4250d34f5f (commit) via 722a48dbe4ea51e798a137cb40663812126b2939 (commit) via 74e225cc701a87a96385ab48dcda440c59013871 (commit) via 9cb8092cf84d18e7435f03eef3963e01ea4e993f (commit) from 6342d92ba53341b61524c001785cd116259e04dc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 473b6ced23aea05af435ab6043b09c4250d34f5f Author: Mark Wielaard Date: Wed Jun 9 14:49:27 2010 +0200 Set vma_cache_p->dentry before use. Bug (on old kernels) introduced by typo in commit ebf779. * runtime/task_finder.c (__stp_call_mmap_callbacks_for_task): Make sure to set vma_cache_p->dentry before usage. commit 722a48dbe4ea51e798a137cb40663812126b2939 Author: Mark Wielaard Date: Wed Jun 9 12:48:14 2010 +0200 Add more error messages when something goes wrong during task_finder detach. * runtime/task_finder.c (stap_utrace_detach): Report when utrace_barrier fails. (stap_utrace_detach_ops): Report how stap_utrace_detach failed. commit 74e225cc701a87a96385ab48dcda440c59013871 Author: Mark Wielaard Date: Wed Jun 9 12:47:11 2010 +0200 Fix task_finder.c f_dentry -> dentry typo. * runtime/task_finder.c (__stp_call_mmap_callbacks_for_task): Fix typo. commit 9cb8092cf84d18e7435f03eef3963e01ea4e993f Author: Mark Wielaard Date: Wed Jun 9 11:50:48 2010 +0200 Loop on utrace_barrier if utrace_control UTRACE_DETACH returns -EINPROGRESS. When utrace_control(tsk, eng, UTRACE_DETACH) returns -EINPROGRESS that means there are still handlers running. So loop on utrace_barrier(tsk, eng) in that case, till it no longer returns -ERESTARTSYS. That makes sure that no engine handler will be called afterwards, so we can safely unload the stap module. Not doing this might have caused PR11672 (utrace_report_syscall_exit crash), although we don't yet have a simple reproducer for that issue. * runtime/itrace.c (remove_usr_itrace_info): Loop on utrace_barrier if utrace_control returned -EINPROGRESS. * runtime/task_finder.c (stap_utrace_detach): Likewise. (stap_utrace_detach_ops): Likewise. And warn if stap_utrace_detach didn't return successfully. (__stp_utrace_attach): Loop on -ERESTARTSYS after utrace_barrier. (__stp_utrace_task_finder_target_quiesce): Likewise. ----------------------------------------------------------------------- Summary of changes: runtime/itrace.c | 5 +++++ runtime/task_finder.c | 45 ++++++++++++++++++++++++++++++++------------- 2 files changed, 37 insertions(+), 13 deletions(-) hooks/post-receive -- systemtap: system-wide probe/trace tool