From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7791 invoked by alias); 27 Jun 2012 20:39:36 -0000 Received: (qmail 7737 invoked by uid 9896); 27 Jun 2012 20:39:35 -0000 Date: Wed, 27 Jun 2012 20:39:00 -0000 Message-ID: <20120627203935.7726.qmail@sourceware.org> From: cmeek@sourceware.org To: systemtap-cvs@sourceware.org Subject: [SCM] systemtap: system-wide probe/trace tool branch, master, updated. release-1.8-28-g33631d5 X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 7eaca571afab35e8e6263d3c74991c28efdd6b98 X-Git-Newrev: 33631d57fcf18c3981b83d786b01573cf1a7cf9c Mailing-List: contact systemtap-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-cvs-owner@sourceware.org List-Archive: Reply-To: systemtap@sourceware.org X-SW-Source: 2012-q2/txt/msg00188.txt.bz2 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "systemtap: system-wide probe/trace tool". The branch, master has been updated via 33631d57fcf18c3981b83d786b01573cf1a7cf9c (commit) via d76bb5603b4d92c4eb4db27bad7cb6fb7b2a43cc (commit) via 81f5fb7456711fbb9d30f498e8577331c8268cab (commit) via f25a919701502268e69c9229e66f9c281de84626 (commit) via d8f31d0a4e43f4821e7969b70f0e537b077391af (commit) via ef187c9647722b869da2ea34d181832af77ecd8b (commit) via 067cc66f4c834f00ab693416b887b05e040ea785 (commit) from 7eaca571afab35e8e6263d3c74991c28efdd6b98 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 33631d57fcf18c3981b83d786b01573cf1a7cf9c Author: Chris Meek Date: Wed Jun 27 16:34:51 2012 -0400 PR14016: Fixed VARARGS coverity warning va_end was not called on args in the case of a vaspritf error. commit d76bb5603b4d92c4eb4db27bad7cb6fb7b2a43cc Author: Chris Meek Date: Wed Jun 27 16:33:24 2012 -0400 PR14016: Fixed UNREACHABLE coverity warnings In these three cases, the return "" can never be reached. commit 81f5fb7456711fbb9d30f498e8577331c8268cab Author: Chris Meek Date: Wed Jun 27 16:29:30 2012 -0400 PR14016: Fixed UNCAUGHT_EXCEPT coverity warning Since lex_cast can throw an exception, we just need to catch it. commit f25a919701502268e69c9229e66f9c281de84626 Author: Chris Meek Date: Wed Jun 27 16:25:40 2012 -0400 PR14016: Fixed REVERSE_INULL coverity warnings In both cases we dereference a pointer, then proceed to compare the pointer to NULL. This means the pointer could, potentially have been NULL when we dereference it. commit d8f31d0a4e43f4821e7969b70f0e537b077391af Author: Chris Meek Date: Wed Jun 27 16:20:49 2012 -0400 PR14016: Fixed FORWARD_NULL coverity warnings In all these cases, we compare a variable to NULL, but don't exit, then proceed to dereference that variable. This has the potential to cause problems, so in each case assert the variable is not NULL before dereferencing. commit ef187c9647722b869da2ea34d181832af77ecd8b Author: Chris Meek Date: Wed Jun 27 16:08:20 2012 -0400 PR14016: Fixed DEADCODE coverity warnings csclient.cxx: CERTS will always be NULL when it reaches the cleanup. Added an assert, just for clarity and as an extra check. staprun.c r is no longer used in the for loop, so comparing it against 0 will always fail, as its explicitly set to 0 before the loop, and never changed. Safe to just remove it. translate.cxx Since eh_frame_*_seen variables were set to false within the loop, and only one could be changed to true on a given itteration, they could never be true at the same time. This would just cause the loop to continue execution longer than needed. By initializing them outside the loop, we can exit as soon as we've found what we need. commit 067cc66f4c834f00ab693416b887b05e040ea785 Author: Chris Meek Date: Wed Jun 27 15:56:50 2012 -0400 PR14016: Fixed CHECKED_RETURN coverity warnings tapsets.cxx: Return value "r" of glob was not checked. tapset-netfilter.cxx: Return value of get_param was not checked. We should have checked this one, since the protocol family is now required. ----------------------------------------------------------------------- Summary of changes: csclient.cxx | 3 +-- stap-serverd.cxx | 12 ++++++++++-- staplog.c | 1 + staprun/relay.c | 2 +- staprun/staprun.c | 5 +---- tapset-netfilter.cxx | 4 +++- tapsets.cxx | 12 ++++++++++-- translate.cxx | 7 ++----- util.cxx | 5 ++++- 9 files changed, 33 insertions(+), 18 deletions(-) hooks/post-receive -- systemtap: system-wide probe/trace tool