Re: [PATCH] stp_for_each_cpu: use for_each_possible_cpu() on kernel >= 2.6.28

Re: [PATCH] stp_for_each_cpu: use for_each_possible_cpu() on kernel >= 2.6.28

[Wenji Huang]

It's my fault not to find the regression. Maybe we can adoptsrikar's suggestion to use for_each_cpu_mask always since there is no related code change from rc4 to now. Regards,Wenji

Re: [PATCH] stp_for_each_cpu: use for_each_possible_cpu() on kernel >= 2.6.28

[Wenji Huang]

Eduardo Habkost wrote:
> It looks like for_each_cpu() interface has changed again on tip.git,
> breaking stp_for_each_cpu.
> 
> The error I get when compiling a stap module here is:
> 
>  /usr/local/share/systemtap/runtime/stat.c: In function ‘_stp_stat_get’:
>  /usr/local/share/systemtap/runtime/stat.c:213: error: incompatible type for argument 2 of ‘cpumask_next’
> 
> Using for_each_possible_cpu() should be equivalent to
> for_each_cpu(cpu, cpu_possible_map), but its interface didn't change
> like for_each_cpu() did.
> 
> I kept the 2.6.28 #ifdef just in case, but for_each_possible_cpu()
> should work even on older kernels.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  runtime/runtime.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/runtime/runtime.h b/runtime/runtime.h
> index 7507e59..90113b6 100644
> --- a/runtime/runtime.h
> +++ b/runtime/runtime.h
> @@ -41,7 +41,7 @@
>  
>  #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,28)
>  #ifndef stp_for_each_cpu
> -#define stp_for_each_cpu(cpu)  for_each_cpu((cpu), cpu_possible_map)
> +#define stp_for_each_cpu(cpu)  for_each_possible_cpu((cpu))
>  #endif
>  #else
>  #ifndef stp_for_each_cpu
It's my fault not to find the regression. I guess maybe we can adopt
srikar's suggestion to use for_each_cpu_mask always since there is no
related code change from rc4 to rc5.


Regards,
Wenji

Re: [PATCH] stp_for_each_cpu: use for_each_possible_cpu() on kernel >= 2.6.28

[Masami Hiramatsu]

Eduardo Habkost wrote:
> On Wed, Nov 19, 2008 at 09:42:30AM -0500, Masami Hiramatsu wrote:
>> Hi Eduardo,
>>
>> I think you'd better add new autoconf-foreachcpu.c for checking existence of
>> for_each_cpu_possible() macro, instead of checking KERNEL_VERSION.
> 
> Why? for_each_cpu_possible() exists since 2.6.17. The original
> for_each_cpu() fix didn't use an autoconf-*.c check.

Oh, in that case, it's ok for me.

Thank you,
-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com

Re: [PATCH] stp_for_each_cpu: use for_each_possible_cpu() on kernel >= 2.6.28

[Eduardo Habkost]

On Wed, Nov 19, 2008 at 09:42:30AM -0500, Masami Hiramatsu wrote:
> Hi Eduardo,
>
> I think you'd better add new autoconf-foreachcpu.c for checking existence of
> for_each_cpu_possible() macro, instead of checking KERNEL_VERSION.

Why? for_each_cpu_possible() exists since 2.6.17. The original
for_each_cpu() fix didn't use an autoconf-*.c check.


>
> Thank you,
>
> Eduardo Habkost wrote:
>> It looks like for_each_cpu() interface has changed again on tip.git,
>> breaking stp_for_each_cpu.
>>
>> The error I get when compiling a stap module here is:
>>
>>  /usr/local/share/systemtap/runtime/stat.c: In function ‘_stp_stat_get’:
>>  /usr/local/share/systemtap/runtime/stat.c:213: error: incompatible type for argument 2 of ‘cpumask_next’
>>
>> Using for_each_possible_cpu() should be equivalent to
>> for_each_cpu(cpu, cpu_possible_map), but its interface didn't change
>> like for_each_cpu() did.
>>
>> I kept the 2.6.28 #ifdef just in case, but for_each_possible_cpu()
>> should work even on older kernels.
>>
>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>> ---
>>  runtime/runtime.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/runtime/runtime.h b/runtime/runtime.h
>> index 7507e59..90113b6 100644
>> --- a/runtime/runtime.h
>> +++ b/runtime/runtime.h
>> @@ -41,7 +41,7 @@
>>   #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,28)
>>  #ifndef stp_for_each_cpu
>> -#define stp_for_each_cpu(cpu)  for_each_cpu((cpu), cpu_possible_map)
>> +#define stp_for_each_cpu(cpu)  for_each_possible_cpu((cpu))
>>  #endif
>>  #else
>>  #ifndef stp_for_each_cpu
>
> -- 
> Masami Hiramatsu
>
> Software Engineer
> Hitachi Computer Products (America) Inc.
> Software Solutions Division
>
> e-mail: mhiramat@redhat.com
>
>

-- 
Eduardo

Re: [PATCH] stp_for_each_cpu: use for_each_possible_cpu() on kernel >= 2.6.28

[Masami Hiramatsu]

Hi Eduardo,

I think you'd better add new autoconf-foreachcpu.c for checking existence of
for_each_cpu_possible() macro, instead of checking KERNEL_VERSION.

Thank you,

Eduardo Habkost wrote:
> It looks like for_each_cpu() interface has changed again on tip.git,
> breaking stp_for_each_cpu.
> 
> The error I get when compiling a stap module here is:
> 
>  /usr/local/share/systemtap/runtime/stat.c: In function ‘_stp_stat_get’:
>  /usr/local/share/systemtap/runtime/stat.c:213: error: incompatible type for argument 2 of ‘cpumask_next’
> 
> Using for_each_possible_cpu() should be equivalent to
> for_each_cpu(cpu, cpu_possible_map), but its interface didn't change
> like for_each_cpu() did.
> 
> I kept the 2.6.28 #ifdef just in case, but for_each_possible_cpu()
> should work even on older kernels.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  runtime/runtime.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/runtime/runtime.h b/runtime/runtime.h
> index 7507e59..90113b6 100644
> --- a/runtime/runtime.h
> +++ b/runtime/runtime.h
> @@ -41,7 +41,7 @@
>  
>  #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,28)
>  #ifndef stp_for_each_cpu
> -#define stp_for_each_cpu(cpu)  for_each_cpu((cpu), cpu_possible_map)
> +#define stp_for_each_cpu(cpu)  for_each_possible_cpu((cpu))
>  #endif
>  #else
>  #ifndef stp_for_each_cpu

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com

[PATCH] stp_for_each_cpu: use for_each_possible_cpu() on kernel >= 2.6.28

[Eduardo Habkost]

It looks like for_each_cpu() interface has changed again on tip.git,
breaking stp_for_each_cpu.

The error I get when compiling a stap module here is:

 /usr/local/share/systemtap/runtime/stat.c: In function ‘_stp_stat_get’:
 /usr/local/share/systemtap/runtime/stat.c:213: error: incompatible type for argument 2 of ‘cpumask_next’

Using for_each_possible_cpu() should be equivalent to
for_each_cpu(cpu, cpu_possible_map), but its interface didn't change
like for_each_cpu() did.

I kept the 2.6.28 #ifdef just in case, but for_each_possible_cpu()
should work even on older kernels.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 runtime/runtime.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/runtime/runtime.h b/runtime/runtime.h
index 7507e59..90113b6 100644
--- a/runtime/runtime.h
+++ b/runtime/runtime.h
@@ -41,7 +41,7 @@
 
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,28)
 #ifndef stp_for_each_cpu
-#define stp_for_each_cpu(cpu)  for_each_cpu((cpu), cpu_possible_map)
+#define stp_for_each_cpu(cpu)  for_each_possible_cpu((cpu))
 #endif
 #else
 #ifndef stp_for_each_cpu
-- 
1.5.5.GIT