From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31621 invoked by alias); 14 Feb 2006 08:27:39 -0000 Received: (qmail 31614 invoked by uid 22791); 14 Feb 2006 08:27:38 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,FORGED_RCVD_HELO,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 14 Feb 2006 08:27:34 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id k1E8RW55013613 for ; Tue, 14 Feb 2006 03:27:32 -0500 Received: from post-office.corp.redhat.com (post-office.corp.redhat.com [172.16.52.227]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id k1E8RW102327; Tue, 14 Feb 2006 03:27:32 -0500 Received: from localhost.localdomain (sebastian-int.corp.redhat.com [172.16.52.221]) by post-office.corp.redhat.com (8.11.6/8.11.6) with ESMTP id k1E8RVt29720; Tue, 14 Feb 2006 03:27:31 -0500 Subject: Re: Global constants From: Mark McLoughlin To: Martin Hunt Cc: "Frank Ch. Eigler" , systemtap@sourceware.org In-Reply-To: <1139866918.3942.37.camel@monkey2> References: <1139852331.11054.17.camel@localhost.localdomain> <1139859707.3942.11.camel@monkey2> <1139861652.11054.40.camel@localhost.localdomain> <1139862190.3942.33.camel@monkey2> <1139863461.11054.51.camel@localhost.localdomain> <1139866918.3942.37.camel@monkey2> Content-Type: multipart/mixed; boundary="=-PRf+3z13LOoT75QPr61a" Date: Tue, 14 Feb 2006 08:27:00 -0000 Message-Id: <1139905649.3683.3.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.4.0 X-Virus-Checked: Checked by ClamAV on sourceware.org X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q1/txt/msg00510.txt.bz2 --=-PRf+3z13LOoT75QPr61a Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 501 On Mon, 2006-02-13 at 13:41 -0800, Martin Hunt wrote: > On Mon, 2006-02-13 at 20:44 +0000, Mark McLoughlin wrote: > > O_CREAT works fine, but try O_ASYNC (AFAIR) > > Yeah, a quirk of the kernel headers is that they define FASYNC instead > of the equivalent O_ASYNC. The user headers define both > # define FASYNC O_ASYNC Yes, I thought there was another missing value, though. Turns out that was O_NDCTTY which is merely a typo - it should be O_NOCTTY. Patch attached. Cheers, Mark. --=-PRf+3z13LOoT75QPr61a Content-Disposition: attachment; filename=systemtap-0.5.4-noctty.patch Content-Type: text/x-patch; name=systemtap-0.5.4-noctty.patch; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-length: 755 --- systemtap-0.5.4/tapset/aux_syscalls.stp.noctty 2006-02-14 08:20:02.000000000 +0000 +++ systemtap-0.5.4/tapset/aux_syscalls.stp 2006-02-14 08:20:16.000000000 +0000 @@ -305,7 +305,7 @@ if(f & 2048) bs="O_NONBLOCK|".bs if(f & 1024) bs="O_APPEND|".bs if(f & 512) bs="O_TRUNC|".bs - if(f & 256) bs="O_NDCTTY|".bs + if(f & 256) bs="O_NOCTTY|".bs if(f & 128) bs="O_EXCL|".bs if(f & 64) bs="O_CREAT|".bs if((f & 3) == 2) bs="O_RDWR|".bs @@ -419,7 +419,7 @@ if(f==2048) return "O_NONBLOCK" if(f==1024) return "O_APPEND" if(f==512) return "O_TRUNC" - if(f==256) return "O_NDCTTY" + if(f==256) return "O_NOCTTY" if(f==128) return "O_EXCL" if(f==64) return "O_CREAT" if(f==2) return "O_RDWR" --=-PRf+3z13LOoT75QPr61a--