From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14897 invoked by alias); 1 Mar 2006 18:32:00 -0000 Received: (qmail 14889 invoked by uid 22791); 1 Mar 2006 18:32:00 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 01 Mar 2006 18:31:58 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id k21IVuGQ016091 for ; Wed, 1 Mar 2006 13:31:56 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id k21IVu111645; Wed, 1 Mar 2006 13:31:56 -0500 Received: from vpn83-137.boston.redhat.com (vpn83-137.boston.redhat.com [172.16.83.137]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id k21IVsDQ013855; Wed, 1 Mar 2006 13:31:55 -0500 Subject: syscall tapset reorg again? From: Martin Hunt To: Hien Nguyen Cc: "systemtap@sources.redhat.com" Content-Type: text/plain Organization: Red Hat Inc. Date: Wed, 01 Mar 2006 18:32:00 -0000 Message-Id: <1141237913.3385.22.camel@dragon> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-3.fc4) Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q1/txt/msg00669.txt.bz2 Hien, I checked in returnstr(). So a simple probe might look like this: probe syscall.close { printf("%s: %s(%s) = ", execname(), name, argstr) } probe syscall.close.return { printf("%s\n", returnstr(returnp)) } syscalls that return pointers should set returnp to 2 in the return probe to indicate that returnstr should display the output in hex. --- I think it is time to attempt a reorganization of the syscalls. Actually we probably should have done this first. Instead of syscalls.stp, syscalls2.stp and aux_syscalls.stp, I think we need something like syscall_net.stp, syscall_file.stp, syscall_process.stp, syscall_ipc.stp, and syscall_misc.stp. This makes it easier to work on related syscalls. Plus it should speed up the translation process. We can combine the probes with the functions they use. Or perhaps it is better to put them in their own set of files; net_funcs.stp, file_funcs.stp, etc. These could be useful to script writers even if not using the syscall tapset. Martin