From: Martin Hunt <hunt@redhat.com>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: systemtap@sources.redhat.com
Subject: Re: tutorial draft checked in
Date: Fri, 10 Mar 2006 09:32:00 -0000 [thread overview]
Message-ID: <1141983106.3380.46.camel@dragon> (raw)
In-Reply-To: <20060310005104.GF2632@redhat.com>
On Thu, 2006-03-09 at 19:51 -0500, Frank Ch. Eigler wrote:
> Hi -
>
> hunt wrote:
>
> > >This operation is efficient (taking a shared lock) because the
> > >aggregate values are kept separately on each processor, and are only
> > >aggregated across processors on request.
> >
> > Surprised me. I checked and this accurately described the current
> > implementation, but the shared lock is unnecessary and should probably
> > not be mentioned.
> > [...]
>
> This is the subject of bug #2224. The runtime is taking locks, and
> the translator is also emitting locks. In my opinion, the runtime
> should leave the maximum possible locking discretion to the
> translator, since e.g. only the latter knows how to enforce locking
> timeouts over contentious data.
We have argued this again and again. I see no reason why you want the
translator to be more complicated and slower. Surely we have better
things to work on.
For the specific case of pmaps I am sure I spent more time arguing about
it than writing it. The disadvantages of what you want to do are
1. Reader locks are slow. They don't scale as well as per-cpu spinlocks.
2. The translator holds the lock during the whole probe vs the runtime
which holds the lock as short a time as possible.
3. Having the translator handle low-level locking eliminates the
possibility of switching the runtime to a more efficient lockless
solution later.
> Anyway, if the advantage of having unshared per-cpu locks for the <<<
> case was large, the translator could adopt the technique just as
> easily.
Obviously not true. It is already done and works in the runtime pmap
implementation.
I ran a few benchmarks to demonstrate pmaps scalability and measure the
additional overhead from the translator reader-writer locks.
Regular maps
probe TEST {
syscalls[probefunc()]++
}
Pmaps
probe TEST {
syscalls[probefunc()] <<< 1
}
Running on a dual-processor hyperthreaded machine.
I ran threads that were making syscalls as fast as possible.
Results are Kprobes/sec
1 thread 4 threads
Regular 340 500
Pmaps 340 940
Pmaps* 380 1040
Pmaps* is pmaps with the redundant reader-writer locks removed.
Measured overhead of those locks is approximately 10% of the cpu time
for this test case.
next prev parent reply other threads:[~2006-03-10 9:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-03 17:56 Frank Ch. Eigler
2006-03-03 21:16 ` Martin Hunt
2006-03-03 21:50 ` William Cohen
2006-03-10 0:51 ` Frank Ch. Eigler
2006-03-10 9:32 ` Martin Hunt [this message]
2006-03-10 12:50 ` Frank Ch. Eigler
2006-03-07 0:47 ` Jim Keniston
2006-03-10 17:55 ` Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1141983106.3380.46.camel@dragon \
--to=hunt@redhat.com \
--cc=fche@redhat.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).