public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@redhat.com>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: "Keshavamurthy, Anil S" <anil.s.keshavamurthy@intel.com>,
	        SystemTAP <systemtap@sources.redhat.com>,
	        Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	        Prasanna S Panchamukhi <prasanna@in.ibm.com>,
	        Satoshi Oshima <soshima@redhat.com>,
	Hideo Aoki <haoki@redhat.com>,
	        Yumiko Sugita <yumiko.sugita.yf@hitachi.com>,
	        Jim Keniston <jkenisto@us.ibm.com>,
	Martin Bligh <mbligh@google.com>,
	        Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [RFC][PATCH 0/4][kprobe](djprobe) Direct jump optimized kprobes
Date: Mon, 27 Nov 2006 16:56:00 -0000	[thread overview]
Message-ID: <1164632388.22536.109.camel@earth> (raw)
In-Reply-To: <4562A150.2030606@hitachi.com>

On Tue, 2006-11-21 at 15:48 +0900, Masami Hiramatsu wrote:
> Hi Anil and Ingo,
> 
> I integrated the essence of the djprobe into kprobes. For this
> purpose, I introduced the length member in the kprobe structure.
> 
> If you'd like to use it, specify the length of the instructions
> which will be replaced by a jump code to that length member.
> (Of cause, you also have to check whether the instructions are
>  relocatable and don't include any jump target.) 

cool stuff!

I'm wondering whether it could be made a 100% transparent speedup to
kprobes: how hard would it be to do a simplified disassembly of the
target address to automate the 'this kprobe can safely be turned into a
djprobe transparently' step, and hence to make this change completely
invisible to user-space utilities? Userspace would have to do something
like this anyway (unless i'm missing something), correct?

It might also be useful to implement some sort of query functionality,
to enable userspace to see which probes are sped up and which are not.
This could be a list of all probe points in /sys or /proc or /debugfs -
or a syscall extension - whichever fits the purpose best.

also, it would be nice to submit to this Andrew for -mm inclusion.

	Ingo

  parent reply	other threads:[~2006-11-27 13:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-21  6:53 Masami Hiramatsu
2006-11-21  6:55 ` [RFC][PATCH 1/4][kprobe](djprobe) generalize the length of the instruction Masami Hiramatsu
2006-11-21  6:56 ` [RFC][PATCH 2/4][kprobe](djprobe) Direct jump optimized kprobes core patch Masami Hiramatsu
2006-11-21  6:57 ` [RFC][PATCH 3/4][kprobe](djprobe) djprobe for i386 architecture code Masami Hiramatsu
2006-11-21  6:59 ` [RFC][PATCH 4/4][kprobe](djprobe) delayed invoking commit_kprobes() Masami Hiramatsu
2006-11-21 14:24 ` [RFC][kprobe](djprobe) djprobe examples Masami Hiramatsu
2006-11-27 16:56 ` Ingo Molnar [this message]
2006-11-28  0:05   ` [RFC][PATCH 0/4][kprobe](djprobe) Direct jump optimized kprobes Frank Ch. Eigler
2006-11-28  2:44     ` Satoshi Oshima
2006-11-28 15:01       ` Ingo Molnar
2006-11-28 15:56         ` Masami Hiramatsu
2006-11-28 16:34           ` Ingo Molnar
2006-11-28 17:52             ` Frank Ch. Eigler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1164632388.22536.109.camel@earth \
    --to=mingo@redhat.com \
    --cc=ananth@in.ibm.com \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=gregkh@suse.de \
    --cc=haoki@redhat.com \
    --cc=jkenisto@us.ibm.com \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mbligh@google.com \
    --cc=prasanna@in.ibm.com \
    --cc=soshima@redhat.com \
    --cc=systemtap@sources.redhat.com \
    --cc=yumiko.sugita.yf@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).