public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@osdl.org>,
	  Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@redhat.com>,
	  Greg Kroah-Hartman <gregkh@suse.de>,
	  Christoph Hellwig <hch@infradead.org>,
	ltt-dev@shafik.org,   systemtap@sources.redhat.com,
	Douglas Niehaus <niehaus@eecs.ku.edu>,
	  "Martin J. Bligh" <mbligh@mbligh.org>,
	  Thomas Gleixner <tglx@linutronix.de>,
	  Paul Mackerras <paulus@samba.org>,
	  Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Subject: [PATCH 03/09] atomic.h : i386 type safety fix
Date: Thu, 25 Jan 2007 18:06:00 -0000	[thread overview]
Message-ID: <11697417552523-git-send-email-mathieu.desnoyers@polymtl.ca> (raw)
In-Reply-To: <11697417541743-git-send-email-mathieu.desnoyers@polymtl.ca>

atomic.h : i386 type safety fix

This patch removes an explicit cast to an integer type for the result returned
by cmpxchg. It is not per se a problem on the i386 architecture, because
sizeof(int) == sizeof(long), but whenever this code is cut'n'pasted to a
different architecture (which happened at least for x86_64), it would simply
accept passing an atomic64_t value as parameter to cmpxchg, xchg and
add_unless, having 64 bits inputs casted to 32 bits.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>

--- a/include/asm-i386/atomic.h
+++ b/include/asm-i386/atomic.h
@@ -207,8 +207,9 @@ static __inline__ int atomic_sub_return(int i, atomic_t *v)
 	return atomic_add_return(-i,v);
 }
 
-#define atomic_cmpxchg(v, old, new) ((int)cmpxchg(&((v)->counter), old, new))
-#define atomic_xchg(v, new) (xchg(&((v)->counter), new))
+#define atomic_cmpxchg(v, old, new) \
+	((__typeof__((v)->counter))cmpxchg(&((v)->counter), (old), (new)))
+#define atomic_xchg(v, new) (xchg(&((v)->counter), (new)))
 
 /**
  * atomic_add_unless - add unless the number is a given value
@@ -221,7 +222,7 @@ static __inline__ int atomic_sub_return(int i, atomic_t *v)
  */
 #define atomic_add_unless(v, a, u)				\
 ({								\
-	int c, old;						\
+	__typeof__((v)->counter) c, old;			\
 	c = atomic_read(v);					\
 	for (;;) {						\
 		if (unlikely(c == (u)))				\

  parent reply	other threads:[~2007-01-25 18:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-25 16:16 [PATCH 00/09] atomic.h : standardizing atomic primitives Mathieu Desnoyers
2007-01-25 16:21 ` [PATCH 02/09] atomic.h : Complete atomic_long operations in asm-generic Mathieu Desnoyers
2007-01-26  2:54   ` Mathieu Desnoyers
2007-01-25 16:26 ` [PATCH 06/09] atomic.h : Add atomic64 cmpxchg, xchg and add_unless to parisc Mathieu Desnoyers
2007-01-25 16:26 ` [PATCH 01/09] atomic.h : Add atomic64 cmpxchg, xchg and add_unless to alpha Mathieu Desnoyers
2007-01-25 17:06 ` [PATCH 04/09] atomic.h : Add atomic64 cmpxchg, xchg and add_unless to ia64 Mathieu Desnoyers
2007-01-25 18:06 ` Mathieu Desnoyers [this message]
2007-01-25 18:11 ` [PATCH 07/09] atomic.h : Add atomic64 cmpxchg, xchg and add_unless to powerpc Mathieu Desnoyers
2007-01-25 18:12 ` [PATCH 09/09] atomic.h : Add atomic64 cmpxchg, xchg and add_unless to x86_64 Mathieu Desnoyers
2007-01-25 18:16 ` [PATCH 05/09] atomic.h : Add atomic64 cmpxchg, xchg and add_unless to mips Mathieu Desnoyers
2007-01-25 20:22 ` [PATCH 08/09] atomic.h : Add atomic64 cmpxchg, xchg and add_unless to sparc64 Mathieu Desnoyers
2007-01-26 11:32 ` [PATCH 00/09] atomic.h : standardizing atomic primitives Peter Zijlstra
2007-01-27  9:49 ` Andrew Morton
2007-01-27 10:19 ` Andrew Morton
2007-01-27 17:36   ` Mathieu Desnoyers
2007-01-27 18:11   ` [Ltt-dev] " Mathieu Desnoyers
2007-01-27 20:06     ` Andrew Morton
2007-01-27 20:10       ` Willy Tarreau
2007-01-27 20:31         ` Andrew Morton
2007-01-27 20:34           ` Martin Bligh
2007-01-27 22:51           ` Jan Dittmer
2007-01-29 18:39       ` Richard Purdie
2007-01-29 18:56         ` Randy Dunlap
2007-01-29 19:17           ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2007-01-12  1:35 Mathieu Desnoyers
2007-01-12  2:21 ` [PATCH 03/09] atomic.h : i386 type safety fix Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11697417552523-git-send-email-mathieu.desnoyers@polymtl.ca \
    --to=mathieu.desnoyers@polymtl.ca \
    --cc=akpm@osdl.org \
    --cc=gregkh@suse.de \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltt-dev@shafik.org \
    --cc=mbligh@mbligh.org \
    --cc=mingo@redhat.com \
    --cc=niehaus@eecs.ku.edu \
    --cc=paulus@samba.org \
    --cc=systemtap@sources.redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).