From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24226 invoked by alias); 26 Jan 2007 11:32:41 -0000 Received: (qmail 24217 invoked by uid 22791); 26 Jan 2007 11:32:40 -0000 X-Spam-Status: No, hits=-0.6 required=5.0 tests=BAYES_00,DNS_FROM_RFC_POST,FORGED_RCVD_HELO,SPF_PASS,TW_JL,TW_PX X-Spam-Check-By: sourceware.org Received: from amsfep17-int.chello.nl (HELO amsfep18-int.chello.nl) (213.46.243.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 26 Jan 2007 11:32:32 +0000 Received: from [192.168.0.111] (really [62.194.129.232]) by amsfep19-int.chello.nl (InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id <20070126100724.RTMI19932.amsfep19-int.chello.nl@[192.168.0.111]>; Fri, 26 Jan 2007 11:07:24 +0100 Subject: Re: [PATCH 00/09] atomic.h : standardizing atomic primitives From: Peter Zijlstra To: Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Andrew Morton , Ingo Molnar , Greg Kroah-Hartman , Christoph Hellwig , ltt-dev@shafik.org, systemtap@sources.redhat.com, Douglas Niehaus , "Martin J. Bligh" , Thomas Gleixner , Paul Mackerras , Jeff Dike In-Reply-To: <11697417541743-git-send-email-mathieu.desnoyers@polymtl.ca> References: <11697417541743-git-send-email-mathieu.desnoyers@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Date: Fri, 26 Jan 2007 11:32:00 -0000 Message-Id: <1169806002.6189.94.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 8bit Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2007-q1/txt/msg00231.txt.bz2 On Thu, 2007-01-25 at 11:15 -0500, Mathieu Desnoyers wrote: > atomic.h : standardizing atomic primitives > > It mainly adds support for missing 64 bits cmpxchg and 64 bits atomic add > unless. Therefore, principally 64 bits architectures are targeted by these > patches. It also adds the complete list of atomic operations on the atomic_long > type. > > These patches apply on 2.6.20-rc5-git4. ARCH=um SUBARCH=i386 In file included from include2/asm/arch/atomic.h:257, from include2/asm/atomic.h:10, from /usr/src/linux-2.6-git/include/linux/file.h:9, from /usr/src/linux-2.6-git/mm/fadvise.c:12: /usr/src/linux-2.6-git/include/asm-generic/atomic.h: In function ‘atomic_long_add_unless’: /usr/src/linux-2.6-git/include/asm-generic/atomic.h:260: warning: implicit declaration of function ‘cmpxchg’ /usr/src/linux-2.6-git/include/asm-generic/atomic.h: In function ‘atomic_long_xchg’: /usr/src/linux-2.6-git/include/asm-generic/atomic.h:281: warning: implicit declaration of function ‘xchg’ Signed-off-by: Peter Zijlstra --- diff --git a/include/asm-um/atomic.h b/include/asm-um/atomic.h index b683f10..b2766b0 100644 --- a/include/asm-um/atomic.h +++ b/include/asm-um/atomic.h @@ -6,6 +6,7 @@ #define __UM_ATOMIC_H */ #include "linux/kernel.h" +#include "asm/arch/system.h" #include "asm/arch/atomic.h" #endif